- update SDK to fix an issue arising from Available Offline policies targeting unavailable/detached drives and removes the respective policies

- adapt app code to SDK API changes

Author: felix-schwarz

ios-sdk

@@ -482,6 +482,11 @@
             value = "false"
             isEnabled = "NO">
          </EnvironmentVariable>
+         <EnvironmentVariable
+            key = "oc:http.traffic-log-format"
+            value = "string:plain"
+            isEnabled = "YES">
+         </EnvironmentVariable>
       </EnvironmentVariables>
       <AdditionalOptions>
          <AdditionalOption

ownCloud.xcodeproj/xcshareddata/xcschemes/ownCloud.xcscheme

@@ -92,7 +92,7 @@ public class ActionExtension: OCExtension {
 
 public extension OCItem {
 	func isSharedWithUser(in context: ClientContext?) -> Bool {
-		if let context, let core = context.core, core.useDrives, let driveID, let drive = core.drive(withIdentifier: driveID) {
+		if let context, let core = context.core, core.useDrives, let driveID, let drive = core.drive(withIdentifier: driveID, attachedOnly: true) {
 			// On drive-based instances, all items shared with the user are located in the Shares Jail
 			if drive.specialType == .shares {
 				return true

ownCloudAppShared/Client/Actions/Action.swift

@@ -28,7 +28,7 @@ extension OCItemPolicy: UniversalItemListCellContentProvider {
 		content.icon = isFile ? .file : ((location?.isDriveRoot == true) ? .drive : .folder)
 
 		// Title
-		if location?.isDriveRoot == true, let driveID = location?.driveID, let drive = context?.core?.drive(withIdentifier: driveID), let driveName = drive.name {
+		if location?.isDriveRoot == true, let driveID = location?.driveID, let drive = context?.core?.drive(withIdentifier: driveID, attachedOnly: false), let driveName = drive.name {
 			content.title = .drive(name: driveName)
 		} else if let name = location?.lastPathComponent {
 			content.title = isFile ? .file(name: name) : .folder(name: name)

ownCloudAppShared/Client/Collection Views/Cells/UniversalItemListCell Content Providers/OCItemPolicy+UniversalItemListCellContentProvider.swift

@@ -30,7 +30,7 @@ extension OCShare: UniversalItemListCellContentProvider {
 
 		// Title
 		if !showManagementView {
-			if itemLocation.isDriveRoot, let driveID = itemLocation.driveID, let drive = context?.core?.drive(withIdentifier: driveID), let driveName = drive.name {
+			if itemLocation.isDriveRoot, let driveID = itemLocation.driveID, let drive = context?.core?.drive(withIdentifier: driveID, attachedOnly: false), let driveName = drive.name {
 				content.title = .drive(name: driveName)
 			} else if let name = itemLocation.lastPathComponent {
 				content.title = isFile ? .file(name: name) : .folder(name: name)

ownCloudAppShared/Client/Collection Views/Cells/UniversalItemListCell Content Providers/OCShare+UniversalItemListCellContentProvider.swift

@@ -25,7 +25,7 @@ extension OCLocation : DataItemSelectionInteraction {
 	public func openItem(from viewController: UIViewController?, with context: ClientContext?, animated: Bool, pushViewController: Bool, completion: ((Bool) -> Void)?) -> UIViewController? {
 		let driveContext = ClientContext(with: context, modifier: { context in
 			if let driveID = self.driveID, let core = context.core {
-				context.drive = core.drive(withIdentifier: driveID)
+				context.drive = core.drive(withIdentifier: driveID, attachedOnly: false)
 			}
 		})
 		let query = OCQuery(for: self)

ownCloudAppShared/Client/Data Item Interactions/OCLocation+Interactions.swift

@@ -126,7 +126,7 @@ open class ClientItemViewController: CollectionViewController, SortBarDelegate,
 
 			// Set .drive based on location.driveID
 			if let driveID = location?.driveID, let core = context.core {
-				context.drive = core.drive(withIdentifier: driveID)
+				context.drive = core.drive(withIdentifier: driveID, attachedOnly: false)
 			}
 
 			// Use inDataSource as queryDatasource if no query was provided

ownCloudAppShared/Client/View Controllers/ClientItemViewController.swift

@@ -33,7 +33,7 @@ public extension OCLocation {
 	func displayName(in context: ClientContext?) -> String {
 		switch type {
 			case .drive:
-				if let core = context?.core, let driveID, let drive = core.drive(withIdentifier: driveID), let driveName = drive.name {
+				if let core = context?.core, let driveID, let drive = core.drive(withIdentifier: driveID, attachedOnly: false), let driveName = drive.name {
 					return driveName
 				}
 				return "Space".localized
@@ -62,7 +62,7 @@ public extension OCLocation {
 	func displayIcon(in context: ClientContext?, forSidebar: Bool = false) -> UIImage? {
 		switch type {
 			case .drive:
-				if let core = context?.core, let driveID, let drive = core.drive(withIdentifier: driveID), let specialType = drive.specialType {
+				if let core = context?.core, let driveID, let drive = core.drive(withIdentifier: driveID, attachedOnly: false), let specialType = drive.specialType {
 					switch specialType {
 						case .personal:
 							return OCSymbol.icon(forSymbolName: forSidebar ? "person" : "person.fill")

ownCloudAppShared/Client/View Controllers/Location Breadcrumbs/OCLocation+Breadcrumbs.swift

@@ -275,7 +275,7 @@ public class ClientLocationPicker : NSObject {
 
 				case .drive:
 					if let driveID = location.driveID {
-						title = context.core?.drive(withIdentifier: driveID)?.name
+						title = context.core?.drive(withIdentifier: driveID, attachedOnly: false)?.name
 					}
 
 				case .folder: break

ownCloudAppShared/Client/View Controllers/Location Picker/ClientLocationPicker.swift

@@ -181,7 +181,7 @@ open class MoreViewHeader: UIView {
 
 			if item.isRoot {
 				if let core, core.useDrives, let driveID = item.driveID {
-					if let drive = core.drive(withIdentifier: driveID) {
+					if let drive = core.drive(withIdentifier: driveID, attachedOnly: false) {
 						itemName = drive.name
 					}
 				} else {