Skip to content
This repository was archived by the owner on Apr 14, 2025. It is now read-only.

Trashbin fails with unknown error when restoring #139

Closed
jnweiger opened this issue Jul 15, 2020 · 9 comments
Closed

Trashbin fails with unknown error when restoring #139

jnweiger opened this issue Jul 15, 2020 · 9 comments
Labels
bug Something isn't working C1-oCIS OCIS-Sprint-17 p3-medium Type:Bug

Comments

@jnweiger
Copy link

On the web gui of owncloud/ocis:1.0.0-beta8 :

  • upload a file
  • delete the file
  • upload the same file again
  • go to trashbin, see the the copy of the file there
  • restore from the trashbin, an error occurs:

image

Expected behaviour:

  • the error message should give the reason "cannot restore in the original location XXX, a file with the same name is already there."
  • and/or (even better) suggest to rename things to resolve that conflict, then restore.
@jnweiger
Copy link
Author

Same as above, but do empty trash:

image

Expected behaviour: Empty trash works.

@individual-it
Copy link
Member

duplicate of https://github.com/owncloud/ocis-reva/issues/118 ?

@micbar micbar transferred this issue from owncloud/ocis Jul 28, 2020
@micbar micbar added bug Something isn't working p3-medium C1-oCIS labels Jul 28, 2020
@kulmann kulmann mentioned this issue Aug 17, 2020
Merged
63 tasks
@exalate-issue-sync exalate-issue-sync bot changed the title Trashbin fails with unknown error Trashbin fails with unknown error when restoring Aug 17, 2020
@butonic
Copy link
Member

butonic commented Aug 19, 2020

fixed by cs3org/reva#1103

@PVince81
Copy link

it's part of owncloud/ocis-reva#447.

@individual-it @phil-davis any tests to enable on ocis-reva to validate this ?

This was referenced Aug 24, 2020
Merged
Merged
@individual-it
Copy link
Member

tests added in owncloud/core#37831 & owncloud/ocis#482
not many passing, need more investigation

@kiranparajuli589 kiranparajuli589 mentioned this issue Aug 26, 2020
Closed
@individual-it
Copy link
Member

bug demonstration tests added in owncloud/ocis#489

@haribhandari07 haribhandari07 mentioned this issue Aug 28, 2020
Merged
10 tasks
@individual-it
Copy link
Member

phoenix tests added in owncloud/web#3982 , taking off QA-team tag

@individual-it individual-it mentioned this issue Sep 2, 2020
Closed
@exalate-issue-sync
Copy link

Artur Neumann commented: current behaiviour is changed, the original file is overwritten without comment. see #196

@jnweiger
Copy link
Author

retested with

Version details ocis-1.0.0-rc1 
OCIS_VERSION:         v1.0.0-rc1
ocis --version:       ocis version 199267c^M
git log:              commit 199267c13e916aa8de027a81dbf6733af820369f (HEAD, tag: refs/tags/v1.0.0-rc1)
eos --version:        EOS 4.6.5 (2019)^M
xrootd -v:            v4.11.0^M
bin/ocis contains:
        owncloud/[email protected]
        owncloud/[email protected]
        owncloud/[email protected]
        owncloud/[email protected]
        owncloud/[email protected]
        owncloud/[email protected]
        owncloud/[email protected]
        owncloud/[email protected]
        owncloud/[email protected]
        owncloud/ocis-pkg/[email protected]
        owncloud/[email protected]
        owncloud/[email protected]
        owncloud/[email protected]
        owncloud/[email protected]
        owncloud/[email protected]
        owncloud/[email protected]

Restore works fine in RC1. No error messages when the target name is free. Appropriate errors when the target file or directory exists. Nothing is overwritten.

@IljaN IljaN mentioned this issue Jan 21, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working C1-oCIS OCIS-Sprint-17 p3-medium Type:Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@PVince81 @butonic @jnweiger @individual-it @micbar @haribhandari07