Skip to content

Clean up Makefile #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
aronerben opened this issue Mar 18, 2021 · 0 comments
Open

Clean up Makefile #446

aronerben opened this issue Mar 18, 2021 · 0 comments
Labels
good first issue Good for newcomers technical debt Refactorings or minor to medium technical changes

Comments

@aronerben
Copy link
Contributor

aronerben commented Mar 18, 2021 •
edited
Loading

We currently have a lot of duplication and noise in the Makefile. We can use variables (for examples for paths like ./_build/default) and loops (for example for listing all tests) to reduce duplication a little bit.

Maybe we can use SIHL_ENV=test dune runtest -j 1 --force --no-buffer test/ to limit concurrently running service tests to 1 and avoid DB conflicts.
@aronerben aronerben added good first issue Good for newcomers technical debt Refactorings or minor to medium technical changes labels Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers technical debt Refactorings or minor to medium technical changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aronerben