un-deprecate icon font

Author: adidahiya

packages/core/src/common/classes.ts

@@ -290,9 +290,7 @@ export const TREE_NODE_SELECTED = `${TREE_NODE}-selected`;
 export const TREE_ROOT = `${NS}-tree-root`;
 
 export const ICON = `${NS}-icon`;
-/** @deprecated use <Icon> components and iconName prop APIs instead */
 export const ICON_STANDARD = `${ICON}-standard`;
-/** @deprecated use <Icon> components and iconName prop APIs instead */
 export const ICON_LARGE = `${ICON}-large`;
 
 /**
@@ -327,11 +325,6 @@ export function elevationClass(elevation: Elevation | undefined) {
 
 /**
  * Returns CSS class for icon name.
- *
- * @deprecated These CSS classes rely on Blueprint's icon fonts, which are a legacy feature and will be
- * removed the next major version (4.x). Use the `<Icon>` React component and `iconName` string enum prop
- * APIs instead – they render SVGs, which do not suffer from the blurriness of icon fonts and have
- * equivalent browser support.
  */
 export function iconClass(iconName: string): string;
 export function iconClass(iconName: undefined): undefined;

packages/core/src/components/icon/icon.md

@@ -6,16 +6,6 @@ See the [**Icons package**](#icons) for a searchable list of all available UI ic
 
 </div>
 
-<div class="@ns-callout @ns-intent-primary @ns-icon-info-sign">
-    <h4 class="@ns-heading">SVG icons in 2.0</h4>
-
-Blueprint 2.0 introduced SVG icon support and moved icon resources to a separate __@blueprintjs/icons__ package.
-The `Icon` component renders SVG paths and the icon classes are no longer used by any Blueprint React component.
-Icon font support has been preserved but should be considered a legacy feature that will be removed in a
-future major version.
-
-</div>
-
 This section describes two ways of using the UI icon font: via React `Icon`
 component to render SVG images or via CSS classes to use the icon font.
 
@@ -55,12 +45,18 @@ import { IconNames } from "@blueprintjs/icons";
 <Icon icon="add" onClick={this.handleAdd} onKeyDown={this.handleAddKeys} />
 ```
 
-```html
+The following React component:
+
+```tsx
 <Icon icon="globe" iconSize={30} />
-<!-- renders the following HTML markup: -->
+```
+
+...renders this HTML markup:
+
+```html
 <svg class="@ns-icon" data-icon="globe" width="30" height="30" viewBox="0 0 20 20">
     <title>globe</title>
-    <path ... />
+    <path d="..."></path>
 </svg>
 ```
 

packages/core/src/components/icon/icon.tsx

@@ -119,7 +119,6 @@ export class Icon extends AbstractPureComponent2<IIconProps & React.DOMAttribute
         // render path elements, or nothing if icon name is unknown.
         const paths = this.renderSvgPaths(pixelGridSize, icon);
 
-        // eslint-disable-next-line deprecation/deprecation
         const classes = classNames(Classes.ICON, Classes.iconClass(icon), Classes.intentClass(intent), className);
         const viewBox = `0 0 ${pixelGridSize} ${pixelGridSize}`;
 

packages/core/test/icon/iconTests.tsx

@@ -55,7 +55,6 @@ describe("<Icon>", () => {
     });
 
     it("prefixed icon renders blank icon", () => {
-        // eslint-disable-next-line deprecation/deprecation
         assert.lengthOf(shallow(<Icon icon={Classes.iconClass("airplane") as any} />).find("path"), 0);
     });