pr feedback

Author: Brian Laub

deadlines/src/main/java/com/palantir/deadlines/DeadlineExpiredReasons.java

@@ -41,14 +41,17 @@ public static <T> Optional<DeadlineExpiredException> parseFromResponse(
         });
     }
 
-    public static int getHttpStatusCode(DeadlineExpiredException.External _exception) {
-        // external deadline expiration is considered a client error
-        return 400;
-    }
-
-    public static int getHttpStatusCode(DeadlineExpiredException.Internal _exception) {
-        // internal deadline expiration is considered a server error
-        return 500;
+    public static int getHttpStatusCode(DeadlineExpiredException exception) {
+        if (exception instanceof DeadlineExpiredException.External) {
+            // external deadline expiration is considered a client error
+            return 400;
+        } else if (exception instanceof DeadlineExpiredException.Internal) {
+            // internal deadline expiration is considered a server error
+            return 500;
+        } else {
+            // anything else is considered a server error
+            return 500;
+        }
     }
 
     public interface ResponseEncodingAdapter<RESPONSE> {

deadlines/src/test/java/com/palantir/deadlines/DeadlineExpiredReasonsTest.java

@@ -28,7 +28,7 @@ class DeadlineExpiredReasonsTest {
 
     @Test
     public void encodes_external_to_response() {
-        DeadlineExpiredException.External exception = DeadlineExpiredException.external();
+        DeadlineExpiredException exception = DeadlineExpiredException.external();
         TestResponse response = new TestResponse();
         response.status = DeadlineExpiredReasons.getHttpStatusCode(exception);
         DeadlineExpiredReasons.encodeToResponse(exception, response, Encoder.INSTANCE);
@@ -38,10 +38,10 @@ public void encodes_external_to_response() {
 
     @Test
     public void encodes_internal_to_response() {
-        DeadlineExpiredException.Internal exception = DeadlineExpiredException.internal();
+        DeadlineExpiredException exception = DeadlineExpiredException.internal();
         TestResponse response = new TestResponse();
         response.status = DeadlineExpiredReasons.getHttpStatusCode(exception);
-        DeadlineExpiredReasons.encodeToResponse(DeadlineExpiredException.internal(), response, Encoder.INSTANCE);
+        DeadlineExpiredReasons.encodeToResponse(exception, response, Encoder.INSTANCE);
         assertThat(response.status).isEqualTo(500);
         assertThat(response.headers).contains(entry(DeadlinesHttpHeaders.DEADLINE_EXPIRED_REASON, "internal"));
     }