@@ -110,7 +110,7 @@ void test_passwordCheckFromFile(void) {
110
110
111
111
int ret ;
112
112
char buf [2 ][256 ];
113
- char * line = NULL ;
113
+ char * line ;
114
114
115
115
FILE * f = fopen (PASSWORDFILE , "r" );
116
116
size_t len = 0 ;
@@ -127,20 +127,21 @@ void test_passwordCheckFromFile(void) {
127
127
fclose (f );
128
128
}
129
129
130
+ char * good = strtok (buf [0 ], "\n" );
131
+ char * bad = strtok (buf [1 ], "\n" );
130
132
131
- ret = strcmp (strtok ( buf [ 0 ], "\n" ) , crypt (GOODPASSWORD , buf [0 ])) == 0 ;
133
+ ret = strcmp (good , crypt (GOODPASSWORD , buf [0 ])) == 0 ;
132
134
CU_ASSERT_TRUE (ret );
133
135
134
- ret = strcmp (strtok ( buf [ 1 ], "\n" ) , crypt (BADPASSWORD , buf [1 ])) == 0 ;
136
+ ret = strcmp (bad , crypt (BADPASSWORD , buf [1 ])) == 0 ;
135
137
CU_ASSERT_TRUE (ret );
136
-
137
138
}
138
139
139
140
void test_badPasswordCheckFromFile (void ) {
140
141
141
142
int ret ;
142
143
char buf [2 ][256 ];
143
- char * line = NULL ;
144
+ char * line ;
144
145
145
146
FILE * f = fopen (PASSWORDFILE , "r" );
146
147
size_t len = 0 ;
@@ -157,11 +158,13 @@ void test_badPasswordCheckFromFile(void) {
157
158
fclose (f );
158
159
}
159
160
161
+ char * bad = strtok (buf [0 ], "\n" );
162
+ char * good = strtok (buf [1 ], "\n" );
160
163
161
- ret = strcmp (strtok ( buf [ 0 ], "\n" ) , crypt (BADPASSWORD , buf [0 ])) == 0 ;
164
+ ret = strcmp (bad , crypt (BADPASSWORD , buf [0 ])) == 0 ;
162
165
CU_ASSERT_FALSE (ret );
163
166
164
- ret = strcmp (strtok ( buf [ 1 ], "\n" ) , crypt (GOODPASSWORD , buf [1 ])) == 0 ;
167
+ ret = strcmp (good , crypt (GOODPASSWORD , buf [1 ])) == 0 ;
165
168
CU_ASSERT_FALSE (ret );
166
169
167
170
}
0 commit comments