Skip to content

Commit f139c11

Browse files
committed
Bugfixing test
1 parent 8e55b2b commit f139c11

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

test/test.c

+10-7
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ void test_passwordCheckFromFile(void) {
110110

111111
int ret;
112112
char buf[2][256];
113-
char* line = NULL;
113+
char* line;
114114

115115
FILE *f = fopen(PASSWORDFILE, "r");
116116
size_t len = 0;
@@ -127,20 +127,21 @@ void test_passwordCheckFromFile(void) {
127127
fclose(f);
128128
}
129129

130+
char* good = strtok(buf[0], "\n");
131+
char* bad = strtok(buf[1], "\n");
130132

131-
ret = strcmp(strtok(buf[0], "\n"), crypt(GOODPASSWORD, buf[0])) == 0;
133+
ret = strcmp(good, crypt(GOODPASSWORD, buf[0])) == 0;
132134
CU_ASSERT_TRUE(ret);
133135

134-
ret = strcmp(strtok(buf[1], "\n"), crypt(BADPASSWORD, buf[1])) == 0;
136+
ret = strcmp(bad, crypt(BADPASSWORD, buf[1])) == 0;
135137
CU_ASSERT_TRUE(ret);
136-
137138
}
138139

139140
void test_badPasswordCheckFromFile(void) {
140141

141142
int ret;
142143
char buf[2][256];
143-
char* line = NULL;
144+
char* line;
144145

145146
FILE *f = fopen(PASSWORDFILE, "r");
146147
size_t len = 0;
@@ -157,11 +158,13 @@ void test_badPasswordCheckFromFile(void) {
157158
fclose(f);
158159
}
159160

161+
char* bad = strtok(buf[0], "\n");
162+
char* good = strtok(buf[1], "\n");
160163

161-
ret = strcmp(strtok(buf[0], "\n"), crypt(BADPASSWORD, buf[0])) == 0;
164+
ret = strcmp(bad, crypt(BADPASSWORD, buf[0])) == 0;
162165
CU_ASSERT_FALSE(ret);
163166

164-
ret = strcmp(strtok(buf[1], "\n"), crypt(GOODPASSWORD, buf[1])) == 0;
167+
ret = strcmp(good, crypt(GOODPASSWORD, buf[1])) == 0;
165168
CU_ASSERT_FALSE(ret);
166169

167170
}

0 commit comments

Comments
 (0)