system-wide/web: Add basic web ui back

Signed-off-by: Francisco Javier Honduvilla Coto <[email protected]>

Author: javierhonduco

cmd/parca-agent/main.go

@@ -48,6 +48,7 @@ import (
 	"github.com/parca-dev/parca-agent/pkg/logger"
 	"github.com/parca-dev/parca-agent/pkg/objectfile"
 	"github.com/parca-dev/parca-agent/pkg/profiler"
+	"github.com/parca-dev/parca-agent/pkg/template"
 )
 
 var (
@@ -134,7 +135,6 @@ func main() {
 		level.Warn(logger).Log("msg", "--temp-dir is deprecated and will be removed in a future release.")
 	}
 
-	mux := http.NewServeMux()
 	reg := prometheus.NewRegistry()
 	reg.MustRegister(
 		collectors.NewBuildInfoCollector(),
@@ -192,76 +192,31 @@ func main() {
 		flags.SamplingRatio,
 	)
 
+	mux := http.NewServeMux()
 	mux.Handle("/metrics", promhttp.HandlerFor(reg, promhttp.HandlerOpts{}))
 	mux.HandleFunc("/debug/pprof/", pprof.Index)
 	mux.HandleFunc("/debug/pprof/cmdline", pprof.Cmdline)
 	mux.HandleFunc("/debug/pprof/profile", pprof.Profile)
 	mux.HandleFunc("/debug/pprof/symbol", pprof.Symbol)
 	mux.HandleFunc("/debug/pprof/trace", pprof.Trace)
-	/* 	// Temporarily comment out the web interface
-		mux.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) {
+	mux.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) {
 		if r.URL.Path == "/favicon.ico" {
 			return
 		}
 		if r.URL.Path == "/" {
 			w.Header().Set("Content-Type", "text/html; charset=utf-8")
-			activeProfilers := tm.ActiveProfilers()
-
+			profilers := pp.Profilers()
 			statusPage := template.StatusPage{}
 
-			for _, profilerSet := range activeProfilers {
-				for _, profiler := range profilerSet {
-					profileType := ""
-					labelSet := labels.Labels{}
-
-					for name, value := range profiler.Labels() {
-						if name == "__name__" {
-							profileType = string(value)
-						}
-						if name != "__name__" {
-							labelSet = append(labelSet,
-								labels.Label{Name: string(name), Value: string(value)})
-						}
-					}
-
-					sort.Sort(labelSet)
-
-					q := url.Values{}
-					q.Add("debug", "1")
-					q.Add("query", labelSet.String())
-
-					statusPage.ActiveProfilers = append(statusPage.ActiveProfilers, template.ActiveProfiler{
-						Type:           profileType,
-						Labels:         labelSet,
-						Interval:       flags.ProfilingDuration,
-						NextStartedAgo: time.Since(profiler.NextProfileStartedAt()),
-						Error:          profiler.LastError(),
-						Link:           fmt.Sprintf("/query?%s", q.Encode()),
-					})
-				}
-			}
-
-			sort.Slice(statusPage.ActiveProfilers, func(j, k int) bool {
-				a := statusPage.ActiveProfilers[j].Labels
-				b := statusPage.ActiveProfilers[k].Labels
-
-				l := len(a)
-				if len(b) < l {
-					l = len(b)
-				}
-
-				for i := 0; i < l; i++ {
-					if a[i].Name != b[i].Name {
-						return a[i].Name < b[i].Name
-					}
-					if a[i].Value != b[i].Value {
-						return a[i].Value < b[i].Value
-					}
-				}
-				// If all labels so far were in common, the set with fewer labels comes first.
-				return len(a)-len(b) < 0
-			})
+			for name, profiler := range profilers {
+				statusPage.ActiveProfilers = append(statusPage.ActiveProfilers, template.ActiveProfiler{
+					Name:           name,
+					Interval:       flags.ProfilingDuration,
+					NextStartedAgo: time.Since(profiler.NextProfileStartedAt()),
+					Error:          profiler.LastError(),
+				})
 
+			}
 			err := template.StatusPageTemplate.Execute(w, statusPage)
 			if err != nil {
 				http.Error(w,
@@ -273,68 +228,8 @@ func main() {
 			return
 		}
 
-		if strings.HasPrefix(r.URL.Path, "/query") {
-			ctx := r.Context()
-			query := r.URL.Query().Get("query")
-			matchers, err := parser.ParseMetricSelector(query)
-			if err != nil {
-				http.Error(w,
-					`query incorrectly formatted, expecting selector in form of: {name1="value1",name2="value2"}`,
-					http.StatusBadRequest,
-				)
-				return
-			}
-
-			// We profile every ProfilingDuration so leaving 1s wiggle room. If after
-			// ProfilingDuration+1s no profile has matched, then there is very likely no
-			// profiler running that matches the label-set.
-			timeout := flags.ProfilingDuration + time.Second
-			ctx, cancel := context.WithTimeout(ctx, timeout)
-			defer cancel()
-
-			profile, err := profileListener.NextMatchingProfile(ctx, matchers)
-			if profile == nil || errors.Is(err, context.Canceled) {
-				http.Error(w, fmt.Sprintf(
-					"No profile taken in the last %s that matches the requested label-matchers query. "+
-						"Profiles are taken every %s so either the profiler matching the label-set has stopped profiling, "+
-						"or the label-set was incorrect.",
-					timeout, flags.ProfilingDuration,
-				), http.StatusNotFound)
-				return
-			}
-			if err != nil {
-				http.Error(w, "Unexpected error occurred: "+err.Error(), http.StatusInternalServerError)
-				return
-			}
-
-			v := r.URL.Query().Get("debug")
-			if v == "1" {
-				w.Header().Set("Content-Type", "text/html; charset=utf-8")
-				q := url.Values{}
-				q.Add("query", query)
-
-				fmt.Fprintf(
-					w,
-					"<p><a title='May take up %s to retrieve' href='/query?%s'>Download Next Pprof</a></p>\n",
-					flags.ProfilingDuration,
-					q.Encode(),
-				)
-				fmt.Fprint(w, "<code><pre>\n")
-				fmt.Fprint(w, profile.String())
-				fmt.Fprint(w, "\n</pre></code>")
-				return
-			}
-
-			w.Header().Set("Content-Type", "application/vnd.google.protobuf+gzip")
-			w.Header().Set("Content-Disposition", "attachment;filename=profile.pb.gz")
-			err = profile.Write(w)
-			if err != nil {
-				level.Error(logger).Log("msg", "failed to write profile", "err", err)
-			}
-			return
-		}
 		http.NotFound(w, r)
-	}) */
+	})
 
 	ctx := context.Background()
 	var g run.Group

pkg/template/statuspage.html

@@ -53,36 +53,26 @@
             <p><b>Active Profilers</b></p>
             <table style="width:100%">
                 <tr>
-                    <th>Profile Type</th>
-                    <th>Labels</th>
+                    <th>Profiler Name</th>
                     <th>Next Profile Started</th>
                     <th>Error</th>
-                    <th>Show Next Profile</th>
                 </tr>
                 {{- range $profiler := .ActiveProfilers }}
                 <tr>
                     <td>
-                        {{ .Type }}
-                    </td>
-                    <td>
-                        {{- range $label := .Labels }}
-                        <span class='label'>{{.Name}}="{{.Value}}"</span>
-                        {{- end }}
+                        {{ .Name }}
                     </td>
                     <td>
                         {{ .NextStartedAgo }} ago
                     </td>
                     <td>
                         {{ .Error }}
                     </td>
-                    <td>
-                        <a title='May take up to {{ .Interval }} to display' href='{{ .Link }}'>Show Next Profile</a>
-                    </td>
                 </tr>
                 {{- else }}
                 <tr>
                     <td>
-                        No active profilers
+                        No active profilers (this should never happen)
                     </td>
                 </tr>
                 {{- end }}

pkg/template/template.go

@@ -18,8 +18,6 @@ import (
 	_ "embed"
 	"html/template"
 	"time"
-
-	"github.com/prometheus/prometheus/model/labels"
 )
 
 //go:embed statuspage.html
@@ -28,12 +26,10 @@ var StatusPageTemplateBytes []byte
 var StatusPageTemplate = template.Must(template.New("statuspage").Parse(string(StatusPageTemplateBytes)))
 
 type ActiveProfiler struct {
-	Type           string
-	Labels         labels.Labels
+	Name           string
 	Interval       time.Duration
 	NextStartedAgo time.Duration
 	Error          error
-	Link           string
 }
 
 type StatusPage struct {

pkg/template/template_test.go

@@ -20,7 +20,6 @@ import (
 	"testing"
 	"time"
 
-	"github.com/prometheus/prometheus/model/labels"
 	"github.com/stretchr/testify/require"
 )
 
@@ -31,18 +30,10 @@ func TestStatusPageTemplate(t *testing.T) {
 	res := bytes.NewBuffer(nil)
 	err = StatusPageTemplate.Execute(res, &StatusPage{
 		ActiveProfilers: []ActiveProfiler{{
-			Type: "test_profile_type",
-			Labels: []labels.Label{{
-				Name:  "name1",
-				Value: "value1",
-			}, {
-				Name:  "name2",
-				Value: "value2",
-			}},
+			Name:           "fake_profiler",
 			Interval:       time.Second * 10,
 			NextStartedAgo: time.Second * 3,
 			Error:          errors.New("test"),
-			Link:           "/test123",
 		}},
 	})
 	require.NoError(t, err)

pkg/template/testdata/statuspage.html

@@ -53,29 +53,20 @@
             <p><b>Active Profilers</b></p>
             <table style="width:100%">
                 <tr>
-                    <th>Profile Type</th>
-                    <th>Labels</th>
+                    <th>Profiler Name</th>
                     <th>Next Profile Started</th>
                     <th>Error</th>
-                    <th>Show Next Profile</th>
                 </tr>
                 <tr>
                     <td>
-                        test_profile_type
-                    </td>
-                    <td>
-                        <span class='label'>name1="value1"</span>
-                        <span class='label'>name2="value2"</span>
+                        fake_profiler
                     </td>
                     <td>
                         3s ago
                     </td>
                     <td>
                         test
                     </td>
-                    <td>
-                        <a title='May take up to 10s to display' href='/test123'>Show Next Profile</a>
-                    </td>
                 </tr>
             </table>
         </div>