Skip to content

Add ability to specify targets to profile #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 of 5 tasks
kakkoyun opened this issue Aug 8, 2022 · 2 comments
Closed
4 of 5 tasks

Add ability to specify targets to profile #690

kakkoyun opened this issue Aug 8, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@kakkoyun
Copy link
Member

kakkoyun commented Aug 8, 2022

This issue is about bringing back the functionality specified by --pod-label-selector and --systemd-units flags we had from the last major release.

      --pod-label-selector=STRING
                                  Label selector to control which Kubernetes
                                  Pods to select.
      --cgroups=CGROUPS,...       Cgroups to profile on this node.
      --systemd-units=SYSTEMD-UNITS,...
                                  [deprecated, use --cgroups instead] systemd
                                  units to profile on this node.

It's removed as part of #627, and the fully featured filtering will be added eventually.

Tasks

  • As an initial implementation, let profiler to capture profiles but just do not send them to the server
  • Specify pods to profile
  • Specify systemd units to profile
  • Specify any target to profile
  • Reject the events in eBPF level if the PID is not as part of a desired target

Related #7

#887 covers almost all of the intended behavior, so we don't need half-measures for now. We need to update the documentation and provide samples of configuration to demonstrate the functionality is equivalent to the flags.

@maxbrunet
Copy link
Member

I discussed with @kakkoyun, he will add back the flags before the next release, while I work on the long-term solution (#7) which may not be ready/stabilized early enough, I'll try to keep the flags as deprecated for backward compatibility

@kakkoyun
Copy link
Member Author

Closing for the sake of #887

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants