Interest in benchmarking? #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

nstarman opened this issue Apr 23, 2025 · 0 comments

Contributor

nstarman commented Apr 23, 2025 •

edited

Loading

Hi @patrick-kidger. If you're interested, I'd be happy to contribute

A more comprehensive test suite, e.g. copy over https://github.com/GalacticDynamics/quaxed/blob/main/tests/test_lax/test_myarray.py & https://github.com/GalacticDynamics/quaxed/blob/main/tests/test_numpy/test_myarray.py which goes through every function. It caught BUG: in Value.default #57 and Problem in _Quaxify.__call__ #58, etc.
A benchmark suite, e.g. https://github.com/GalacticDynamics/unxt/runs/40852395818 to catch performance regressions. I'll probably basically copy over https://github.com/GalacticDynamics/unxt/blob/4c5c3d22a32047ccb5e86d1ad7b71a8ed0c88cf1/tests%2Fbenchmark%2Ftest_quaxed.py, but modify it for a MyArray, like in the test suite.

For the latter, I'd ask you to set up the codspeed integration and test out triggering by PRs.

The text was updated successfully, but these errors were encountered:

nstarman mentioned this issue

tests: lax functions #62

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment