Bump github.com/golangci/golangci-lint from 1.55.2 to 1.62.0 (#224)

* Bump github.com/golangci/golangci-lint from 1.55.2 to 1.62.0

Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.55.2 to 1.62.0.
- [Release notes](https://github.com/golangci/golangci-lint/releases)
- [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md)
- [Commits](golangci/golangci-lint@v1.55.2...v1.62.0)

---
updated-dependencies:
- dependency-name: github.com/golangci/golangci-lint
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Linter fixes

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Josh Spence <[email protected]>

Author: dependabot[bot]

.golangci.yaml

@@ -8,6 +8,7 @@ linters:
     # Temporary
     - 'cyclop'
     - 'dupl'
+    - 'err113'
     - 'exhaustruct'
     - 'forbidigo'
     - 'funlen'
@@ -17,28 +18,19 @@ linters:
     - 'gocritic'
     - 'gocyclo'
     - 'godox'
-    - 'goerr113'
-    - 'gomnd'
     - 'gosec'
     - 'lll'
     - 'maintidx'
+    - 'mnd'
     - 'nestif'
     - 'nlreturn'
     - 'paralleltest'
+    - 'perfsprint'
     - 'revive'
     - 'stylecheck'
     - 'varnamelen'
     - 'wrapcheck'
     - 'wsl'
 
     # Deprecated
-    - 'deadcode'
-    - 'exhaustivestruct'
-    - 'golint'
-    - 'ifshort'
-    - 'interfacer'
-    - 'maligned'
-    - 'nosnakecase'
-    - 'scopelint'
-    - 'structcheck'
-    - 'varcheck'
+    - 'exportloopref'

fields/fwupdate.go

@@ -38,7 +38,7 @@ type firmwareUpdateApiResponseEmbeddedFirmwareDataLink struct {
 	Href *url.URL `json:"href"`
 }
 
-func (l firmwareUpdateApiResponseEmbeddedFirmwareDataLink) MarshalJSON() ([]byte, error) {
+func (l *firmwareUpdateApiResponseEmbeddedFirmwareDataLink) MarshalJSON() ([]byte, error) {
 	var href string
 	if l.Href != nil {
 		href = l.Href.String()

fields/main_test.go

@@ -4,7 +4,8 @@ import (
 	"fmt"
 	"testing"
 
-	assert "github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
 )
 
 func TestFieldInfoFromValidation(t *testing.T) {
@@ -151,7 +152,7 @@ func TestResourceTypes(t *testing.T) {
 
 		err := resource.processJSON(([]byte)(testData))
 
-		assert.Empty(t, err, "No error processing JSON")
+		require.NoError(t, err, "No error processing JSON")
 		assert.Equal(t, expectation.StructName, resource.StructName)
 		assert.Equal(t, expectation.ResourcePath, resource.ResourcePath)
 		assert.Equal(t, expectation.Types, resource.Types)

fields/version_test.go

@@ -74,10 +74,10 @@ func TestLatestUnifiVersion(t *testing.T) {
 		assert.Contains(query["filter"], firmwareUpdateApiFilter("product", unifiControllerProduct))
 
 		resp, err := json.Marshal(respData)
-		require.NoError(err)
+		assert.NoError(err)
 
 		_, err = rw.Write(resp)
-		require.NoError(err)
+		assert.NoError(err)
 	}))
 	defer server.Close()