fix(db-postgres): down migration fails because migrationTableExists doesn't check in the current transaction (#11910)

Fixes #11882

Previously, down migration that dropped the `payload_migrations` table
was failing because `migrationTableExists` doesn't check the current
transaction, only in which you can get a `false` value result.

Author: r1tsuu

packages/drizzle/src/migrateDown.ts

@@ -50,7 +50,8 @@ export async function migrateDown(this: DrizzleAdapter): Promise<void> {
         msg: `Migrated down:  ${migrationFile.name} (${Date.now() - start}ms)`,
       })
 
-      const tableExists = await migrationTableExists(this)
+      const tableExists = await migrationTableExists(this, db)
+
       if (tableExists) {
         await payload.delete({
           id: migration.id,

packages/drizzle/src/migrateRefresh.ts

@@ -54,7 +54,7 @@ export async function migrateRefresh(this: DrizzleAdapter) {
         msg: `Migrated down:  ${migration.name} (${Date.now() - start}ms)`,
       })
 
-      const tableExists = await migrationTableExists(this)
+      const tableExists = await migrationTableExists(this, db)
       if (tableExists) {
         await payload.delete({
           collection: 'payload-migrations',

packages/drizzle/src/migrateReset.ts

@@ -45,7 +45,7 @@ export async function migrateReset(this: DrizzleAdapter): Promise<void> {
         msg: `Migrated down:  ${migrationFile.name} (${Date.now() - start}ms)`,
       })
 
-      const tableExists = await migrationTableExists(this)
+      const tableExists = await migrationTableExists(this, db)
       if (tableExists) {
         await payload.delete({
           id: migration.id,

packages/drizzle/src/utilities/migrationTableExists.ts

@@ -1,6 +1,11 @@
-import type { DrizzleAdapter } from '../types.js'
+import type { LibSQLDatabase } from 'drizzle-orm/libsql'
 
-export const migrationTableExists = async (adapter: DrizzleAdapter): Promise<boolean> => {
+import type { DrizzleAdapter, PostgresDB } from '../types.js'
+
+export const migrationTableExists = async (
+  adapter: DrizzleAdapter,
+  db?: LibSQLDatabase | PostgresDB,
+): Promise<boolean> => {
   let statement
 
   if (adapter.name === 'postgres') {
@@ -20,7 +25,7 @@ export const migrationTableExists = async (adapter: DrizzleAdapter): Promise<boo
   }
 
   const result = await adapter.execute({
-    drizzle: adapter.drizzle,
+    drizzle: db ?? adapter.drizzle,
     raw: statement,
   })
 

test/database/up-down-migration/int.spec.ts

@@ -0,0 +1,58 @@
+/* eslint-disable jest/require-top-level-describe */
+import { existsSync, rmdirSync, rmSync } from 'fs'
+import path from 'path'
+import { buildConfig, getPayload } from 'payload'
+import { fileURLToPath } from 'url'
+
+const filename = fileURLToPath(import.meta.url)
+const dirname = path.dirname(filename)
+
+const describe =
+  process.env.PAYLOAD_DATABASE === 'postgres' ? global.describe : global.describe.skip
+
+const clearMigrations = () => {
+  if (existsSync(path.resolve(dirname, 'migrations'))) {
+    rmSync(path.resolve(dirname, 'migrations'), { force: true, recursive: true })
+  }
+}
+
+describe('SQL migrations', () => {
+  // If something fails - an error will be thrown.
+  // eslint-disable-next-line jest/expect-expect
+  it('should up and down migration successfully', async () => {
+    clearMigrations()
+
+    const { databaseAdapter } = await import(path.resolve(dirname, '../../databaseAdapter.js'))
+
+    const init = databaseAdapter.init
+
+    // set options
+    databaseAdapter.init = ({ payload }) => {
+      const adapter = init({ payload })
+      adapter.migrationDir = path.resolve(dirname, 'migrations')
+      adapter.push = false
+      return adapter
+    }
+
+    const config = await buildConfig({
+      db: databaseAdapter,
+      secret: 'secret',
+      collections: [
+        {
+          slug: 'users',
+          auth: true,
+          fields: [],
+        },
+      ],
+    })
+
+    const payload = await getPayload({ config })
+
+    await payload.db.createMigration({ payload })
+    await payload.db.migrate()
+    await payload.db.migrateDown()
+
+    await payload.db.dropDatabase({ adapter: payload.db as any })
+    await payload.db.destroy?.()
+  })
+})