[DEVEL] setup-testdb invalid function syntax, mktemp: too few X's in template

Address the 3 problems with the setup_testdb.sh script on Linux
1. Invalid function declaration syntax
2. Invalid template syntax for mktemp (missing X characters)
3. Usage of `bash`-only commands in a script that wants to run in `sh` (pushd)

Fixes smartcontractkit#16179

Signed-off-by: Peter Somogyvari <[email protected]>

Author: petermetz

core/scripts/setup_testdb.sh

@@ -1,12 +1,12 @@
-#/bin/sh
+#/bin/bash
 
-function exit_error {
+exit_error() {
     echo "Error: $1"
     exit 1
 }
 # Create a new user and database for development
 # This script is intended to be run on a local development machine
-tdir=$(mktemp -d -t db-dev-user)
+tdir=$(mktemp -d -t db-dev-user.XXX-XXX)
 
 username="chainlink_dev"
 password="insecurepassword"
@@ -44,15 +44,15 @@ echo "##########################################################################
 echo "##########################################################################################################"
 echo ""
 # Run the SQL commands
-psql -U postgres -h localhost -f $tdir/db-dev-user.sql || exit_error "Failed to create user $username and database $database"
+psql -U postgres -h localhost -p 55432 -f $tdir/db-dev-user.sql || exit_error "Failed to create user $username and database $database"
 
 
 #test the connection
-PGPASSWORD=$password psql -U $username -h localhost -d $database -c "SELECT 1"  ||  exit_error "Connection failed for $username to $database"
+PGPASSWORD=$password psql -U $username -h localhost -p 55432 -d $database -c "SELECT 1"  ||  exit_error "Connection failed for $username to $database"
 
 
 
-db_url=$(echo "CL_DATABASE_URL=postgresql://$username:$password@localhost:5432/$database?sslmode=disable")
+db_url=$(echo "CL_DATABASE_URL=postgresql://$username:$password@localhost:55432/$database?sslmode=disable")
 echo $db_url
 repo=$(git rev-parse --show-toplevel)
 pushd $repo