Work on rabbit suggestions

Author: cvvergara

doc/topology/pgr_extractVertices.rst

@@ -31,7 +31,7 @@
 
 .. rubric:: Version 3.3.0
 
-* Classified as **proposed** function
+* Function promoted to proposed.
 
 .. rubric:: Version 3.0.0
 

sql/common/_checkquery.sql

@@ -30,7 +30,6 @@ RETURNS TEXT AS
 $BODY$
 DECLARE
   main_sql TEXT;
-  sqlhint TEXT;
 
 BEGIN
 
@@ -54,7 +53,6 @@ BEGIN
     EXECUTE format('SELECT * FROM ( %1$s ) AS __a__ limit 1', main_sql);
 
     EXCEPTION WHEN OTHERS THEN
-      GET STACKED DIAGNOSTICS sqlhint = PG_EXCEPTION_HINT;
       RAISE EXCEPTION '%', SQLERRM USING HINT = $1, ERRCODE = SQLSTATE;
   END;
 

sql/topology/extractVertices.sql

@@ -60,7 +60,7 @@ BEGIN
     edges_sql := _pgr_checkQuery($1);
     EXCEPTION WHEN OTHERS THEN
       GET STACKED DIAGNOSTICS sqlhint = PG_EXCEPTION_HINT;
-      RAISE EXCEPTION 'FOO %', SQLERRM USING HINT = sqlhint, ERRCODE = SQLSTATE;
+      RAISE EXCEPTION '%', SQLERRM USING HINT = sqlhint, ERRCODE = SQLSTATE;
   END;
 
   has_id := _pgr_checkColumn(edges_sql, 'id', 'ANY-INTEGER', true, dryrun => $2);
@@ -70,8 +70,8 @@ BEGIN
   has_geom := _pgr_checkColumn(edges_sql, 'geom', 'geometry', true, dryrun => $2);
   has_start := _pgr_checkColumn(edges_sql, 'startpoint', 'geometry', true, dryrun => $2);
   has_end   := _pgr_checkColumn(edges_sql, 'endpoint', 'geometry', true, dryrun => $2);
-  has_points = has_start AND has_end;
-  has_st = has_source AND has_target;
+  has_points := has_start AND has_end;
+  has_st := has_source AND has_target;
 
   IF (NOT has_geom) THEN
     IF (has_target AND NOT has_source) THEN