Update to PHPStan 2.0

Author: carlos-granados

composer.json

@@ -20,11 +20,11 @@
         "php": ">=8.0"
     },
     "require-dev": {
-        "php-static-analysis/node-visitor": "dev-main",
-        "php-static-analysis/phpstan-extension": "dev-main",
-        "php-static-analysis/psalm-plugin": "dev-main",
+        "php-static-analysis/node-visitor": "^0.3.2 || dev-main",
+        "php-static-analysis/phpstan-extension": "^0.3.2 || dev-main",
+        "php-static-analysis/psalm-plugin": "^0.3.2 || dev-main",
         "phpstan/extension-installer": "^1.3",
-        "phpstan/phpstan": "^1.8",
+        "phpstan/phpstan": "^1.8 | ^2.0",
         "phpunit/phpunit": "^9.0",
         "symplify/easy-coding-standard": "^12.1",
         "vimeo/psalm": "^5"

phpstan.neon

@@ -3,15 +3,17 @@ parameters:
     paths:
     - src
     - tests
-    featureToggles:
-        readOnlyByPhpDoc: true
 
     ignoreErrors:
     - '#^Constructor of class PhpStaticAnalysis\\Attributes\\[a-zA-Z]+ has an unused parameter \$[a-zA-Z]+\.$#'
     - '#^(Function|Method) [a-zA-Z\:]+\(\) return type has no value type specified in iterable type array.$#'
     - '#^Parameter \#1 \.*\$[a-zA-Z]+ of attribute class PhpStaticAnalysis\\Attributes\\[a-zA-Z]+ constructor expects string, int given.$#'
-    - '#^PHPDoc tag @[a-z\-A-Z]+ has invalid value \(\): Unexpected token "\\n ", expected type at offset [0-9]+$#'
     - '#^Attribute class PhpStaticAnalysis\\Attributes\\[a-zA-Z]+ constructor invoked with [0-9]+ parameter(s)?, [0-9]+ required.$#'
     - '#^Attribute class PhpStaticAnalysis\\Attributes\\[a-zA-Z]+ is not repeatable but is already present above the (property|method).$#'
     - '#^Method [a-zA-Z\:]+\(\) has parameter \$[a-zA-Z]+ with generic class [a-zA-Z]+ but does not specify its types: [a-zA-Z]+$#'
-    - '#^PHPDoc tag @phpstan-self-out contains generic type [a-zA-Z]+<[a-zA-Z]+> but class [a-zA-Z]+ is not generic.$#'
+    - '#^PHPDoc tag @[a-z\-A-Z]+ has invalid value \(\): Unexpected token "\\n ", expected type at offset [0-9]+( on line [0-9]+)?$#'
+    - '#^Possibly impure call to method [a-z\-A-Z]+::[a-z\-A-Z]+\(\) in pure (method|function) ([a-z\-A-Z]+::)?[a-z\-A-Z]+\(\).?$#'
+    - '#^Possibly impure instantiation of class [a-z\-A-Z]+ in pure function [a-z\-A-Z]+\(\).?$#'
+
+includes:
+	- vendor/phpstan/phpstan/conf/bleedingEdge.neon

tests/DeprecatedTest.php

@@ -107,3 +107,8 @@ function functionDeprecated(): bool
     $reflection = new ReflectionFunction(__FUNCTION__);
     return DeprecatedTest::getDeprecatedFromReflection($reflection);
 }
+
+class DeprecatedClass
+{
+    use DeprecatedTestTrait;
+}

tests/ImmutableTest.php

@@ -51,3 +51,8 @@ trait ImmutableTestTrait
 interface ImmutableTestInterface
 {
 }
+
+class ImmutableClass
+{
+    use ImmutableTestTrait;
+}

tests/RequireExtendsTest.php

@@ -22,6 +22,7 @@ public static function getRequireExtendssFromReflection(
             if ($attribute->getName() === RequireExtends::class) {
                 $attribute->newInstance();
                 $extends = $attribute->getArguments()[0];
+                assert(is_string($extends));
             }
         }
 

tests/ReturnsTest.php

@@ -95,6 +95,7 @@ public static function getReturnsFromReflection(
             if ($attribute->getName() === Returns::class) {
                 $attribute->newInstance();
                 $returns = $attribute->getArguments()[0];
+                assert(is_string($returns));
             }
         }
 

tests/SelfOutTest.php

@@ -3,8 +3,10 @@
 declare(strict_types=1);
 
 use PhpStaticAnalysis\Attributes\SelfOut;
+use PhpStaticAnalysis\Attributes\Template;
 use PHPUnit\Framework\TestCase;
 
+#[Template('T')]
 class SelfOutTest extends TestCase
 {
     public function testMethodSelfOut(): void
@@ -84,6 +86,7 @@ private function getSelfOut(string $methodName): string
             if ($attribute->getName() === SelfOut::class) {
                 $attribute->newInstance();
                 $selfOut = $attribute->getArguments()[0];
+                assert(is_string($selfOut));
             }
         }
 

tests/TemplateContravariantTest.php

@@ -3,6 +3,7 @@
 declare(strict_types=1);
 
 use PhpStaticAnalysis\Attributes\TemplateContravariant;
+use PhpStaticAnalysis\Attributes\TemplateUse;
 use PHPUnit\Framework\TestCase;
 
 #[TemplateContravariant('TClass', Exception::class)]
@@ -36,8 +37,11 @@ public static function getTemplateContravariantsFromReflection(
                 $attribute->newInstance();
                 $templateData = $attribute->getArguments();
                 $templateValue = $templateData[0];
-                if (isset($templateData[1]) && $templateData[1] !== null) {
-                    $templateValue .= ' of ' . $templateData[1];
+                assert(is_string($templateValue));
+                if (isset($templateData[1])) {
+                    $className = $templateData[1];
+                    assert(is_string($className));
+                    $templateValue .= ' of ' . $className;
                 }
                 $templates[] = $templateValue;
             }
@@ -56,3 +60,9 @@ trait TemplateContravariantTestTrait
 interface TemplateContravariantTestInterface
 {
 }
+
+#[TemplateUse('TemplateContravariantTestTrait<string>')]
+class ContravariantClass
+{
+    use TemplateContravariantTestTrait;
+}

tests/TemplateCovariantTest.php

@@ -3,6 +3,7 @@
 declare(strict_types=1);
 
 use PhpStaticAnalysis\Attributes\TemplateCovariant;
+use PhpStaticAnalysis\Attributes\TemplateUse;
 use PHPUnit\Framework\TestCase;
 
 #[TemplateCovariant('TClass', Exception::class)]
@@ -36,8 +37,11 @@ public static function getTemplateCovariantsFromReflection(
                 $attribute->newInstance();
                 $templateData = $attribute->getArguments();
                 $templateValue = $templateData[0];
-                if (isset($templateData[1]) && $templateData[1] !== null) {
-                    $templateValue .= ' of ' . $templateData[1];
+                assert(is_string($templateValue));
+                if (isset($templateData[1])) {
+                    $className = $templateData[1];
+                    assert(is_string($className));
+                    $templateValue .= ' of ' . $className;
                 }
                 $templates[] = $templateValue;
             }
@@ -56,3 +60,9 @@ trait TemplateCovariantTestTrait
 interface TemplateCovariantTestInterface
 {
 }
+
+#[TemplateUse('TemplateCovariantTestTrait<string>')]
+class CovariantClass
+{
+    use TemplateCovariantTestTrait;
+}

tests/TemplateExtendsTest.php

@@ -23,6 +23,7 @@ public static function getTemplateExtendssFromReflection(
             if ($attribute->getName() === TemplateExtends::class) {
                 $attribute->newInstance();
                 $extends = $attribute->getArguments()[0];
+                assert(is_string($extends));
             }
         }
 

tests/TemplateTest.php

@@ -4,6 +4,7 @@
 
 use PhpStaticAnalysis\Attributes\Param;
 use PhpStaticAnalysis\Attributes\Template;
+use PhpStaticAnalysis\Attributes\TemplateUse;
 use PHPUnit\Framework\TestCase;
 
 #[Template('TClass')]
@@ -103,8 +104,11 @@ public static function getTemplatesFromReflection(
                 $attribute->newInstance();
                 $templateData = $attribute->getArguments();
                 $templateValue = $templateData[0];
-                if (isset($templateData[1]) && $templateData[1] !== null) {
-                    $templateValue .= ' of ' . $templateData[1];
+                assert(is_string($templateValue));
+                if (isset($templateData[1])) {
+                    $className = $templateData[1];
+                    assert(is_string($className));
+                    $templateValue .= ' of ' . $className;
                 }
                 $templates[] = $templateValue;
             }
@@ -124,6 +128,13 @@ interface TemplateTestInterface
 {
 }
 
+#[TemplateUse('TemplateTestTrait<string>')]
+class TemplateClass
+{
+    use TemplateTestTrait;
+}
+
+
 #[Template('TFunction')]
 #[Param(param: 'TFunction')]
 function functionTemplate($param): array

tests/TypeTest.php

@@ -138,6 +138,7 @@ public static function getTypeFromReflection(
             if ($attribute->getName() === Type::class) {
                 $attribute->newInstance();
                 $type = $attribute->getArguments()[0];
+                assert(is_string($type));
             }
         }