Skip to content

Make local golang-lint as same as on the CI #5687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
khanhtc1202 opened this issue Mar 21, 2025 · 2 comments
Open

Make local golang-lint as same as on the CI #5687

khanhtc1202 opened this issue Mar 21, 2025 · 2 comments
Labels
contribfest good first issue Good for newcomers kind/enhancement New feature or request

Comments

@khanhtc1202
Copy link
Member

What would you like to be added:

Make local golang lint check as same as on the CI

Why is this needed:
@khanhtc1202 khanhtc1202 added kind/enhancement New feature or request good first issue Good for newcomers contribfest labels Mar 21, 2025
@Okabe-Junya
Copy link
Contributor

Hello!

It seems that both local and CI are running the same golangci-lint version (v1.64.7) .
In CI, reviewdog is used, while docker is used locally.

What exactly does "making local and CI the same" refer to?

Thanks!

@Okabe-Junya
Copy link
Contributor

FWIW: Another golangci-lint task is migrating golangci-lint v2

FYI: https://ldez.github.io/blog/2025/03/23/golangci-lint-v2/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contribfest good first issue Good for newcomers kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@khanhtc1202 @Okabe-Junya