Skip to content

How to quote endpoint on Windows? #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mayrstefan opened this issue Sep 21, 2019 · 8 comments
Closed

How to quote endpoint on Windows? #4

mayrstefan opened this issue Sep 21, 2019 · 8 comments

Comments

@mayrstefan
Copy link

It seems to be impossible the register a relative URL like "/metrics" using the plugin on Windows (cmd or powershell).

The URL seems to be either invalid or the quoting messes up the registered service endpoint. Es quoting is different with cf CLI on different operation systems: what is the correct way to register an endpoint with the cli on Windows?

Version used: metric-registrar-cli-windows-amd64-1.3.0

@tremblaysimon
Copy link

Any update on that issue?

@heycait
Copy link

heycait commented Aug 31, 2020

We're taking a look at this now. Was there any particular error message you got?

@heycait
Copy link

heycait commented Sep 1, 2020

We've reproduced this issue and suspect this is actually an issue with the CF CLI plugin library. We've reached out to the CF CLI folks here: https://cloudfoundry.slack.com/archives/C032824SM/p1598999944084900

@kkburr
Copy link
Contributor

kkburr commented Sep 3, 2020

We are still waiting for clarity from the cf cli team. The windows command should be going into this condition, but it's not. We are waiting to learn if this case is something we should account for, or if the cf cli plugin library should handle it.

@d4nielfr4nco
Copy link

@kkburr Any updates on this issue?

@d4nielfr4nco
Copy link

d4nielfr4nco commented Oct 1, 2021

In case anyone is blocked due to this. There is an alternative way to pass the PATH argument. In fact, the second argument can be PATH or URL. The URL must be the route's URL without the scheme. For instance, from the docs, you can register with this alternative way:

cf register-metrics-endpoint example otherexample.com/metrics

Reference

@TimHess
Copy link

TimHess commented Oct 9, 2024

3 years and 2 major CLI versions later, this issue has not been resolved... In addition to the workaround above, this is also easy enough to work around by just using the cf cli from WSL, but it would be nice to see an update here

@mkocher
Copy link
Contributor

mkocher commented Oct 11, 2024

This is a manifestation of the cf cli plugin interface which is well overdue for an overhaul, but is of course subject to competing priorities.

This plugin is generally just syntactic sugar for creating user provided services with a custom log url schema. I recommend using @d4nielfr4nco 's workaround above, or switching to the method documented as Register using syslog drain User Provided Service.

@mkocher mkocher closed this as not planned Won't fix, can't repro, duplicate, stale Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants