feat: correctly detect direct dependencies

Workaround for npm/arborist#60

Author: dominykas

lib/deps.js

@@ -32,6 +32,16 @@ exports.resolve = async ({ packageJson, lockfile }, options) => {
         Fs.writeFileSync(Path.join(path, 'package-lock.json'), JSON.stringify(lockfile, null, '  '));
     }
 
+    const direct = new Set();
+    ['dependencies', 'devDependencies', 'peerDependencies', 'optionalDependencies'].forEach((depType) => {
+
+        if (!packageJson[depType]) {
+            return;
+        }
+
+        Object.keys(packageJson[depType]).forEach((dep) => direct.add(dep));
+    });
+
     const arborist = new Arborist({ path });
 
     await arborist.buildIdealTree();
@@ -40,7 +50,7 @@ exports.resolve = async ({ packageJson, lockfile }, options) => {
 
     internals.walk(arborist.idealTree, (node) => {
 
-        if (node.isTop) {
+        if (node.isRoot) {
             return;
         }
 
@@ -49,8 +59,14 @@ exports.resolve = async ({ packageJson, lockfile }, options) => {
             return;
         }
 
-        if (!deep && !node.parent.isTop) {
+        if (!deep && !node.parent.isRoot) {
+            // only include deep deps when `options.deep` flag is set
+            return;
+        }
+
+        if (!deep && !direct.has(node.name)) {
             // only include deep deps when `options.deep` flag is set
+            // workaround for https://github.com/npm/arborist/issues/60
             return;
         }
 

test/deps.js

@@ -36,6 +36,7 @@ describe('Deps', () => {
             expect(result).to.equal({
                 'ci-info': ['1.6.0', '2.0.0'],
                 'is-ci': ['2.0.0'],
+                'debug': ['4.1.1'],
                 'ms': ['2.1.2']
             });
         });
@@ -50,7 +51,7 @@ describe('Deps', () => {
             expect(result).to.equal({
                 'ci-info': ['1.6.0'],
                 'is-ci': ['2.0.0'],
-                'ms': ['2.1.2']
+                'debug': ['4.1.1']
             });
         });
 

test/fixtures/deps-test/npm-shrinkwrap.json

@@ -5,6 +5,6 @@
     "ci-info": "^1.6.0"
   },
   "devDependencies": {
-    "ms": "^2.1.2"
+    "debug": "^4.1.1"
   }
 }