Skip to content

Commit f9016e1

Browse files
committed
refactor: code to pass ruff check
- Modify `pyproject.toml` to exclude `plotly/graph_objs` from checking for now. - Modify `pyproject.toml` to include `anywidget` in core dependencies (because `plotly/basewidget.py` needs it). - Clean up several hundred complaints from `ruff` about unused variables and imports. - Clean up cases in `tests/**/*.py` where the same function name was used for several tests (which meant that only the last one defined was actually run). - Reformat code after recent changes.
1 parent 0e9500e commit f9016e1

File tree

160 files changed

+734
-1293
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

160 files changed

+734
-1293
lines changed

.circleci/config.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ jobs:
153153
source .venv/bin/activate
154154
uv sync --extra dev_core
155155
- run:
156-
name: Check formatting with ruff
156+
name: Check handwritten code with ruff
157157
command: |
158158
source .venv/bin/activate
159159
ruff check .
@@ -344,7 +344,7 @@ jobs:
344344
curl -LsSf https://astral.sh/uv/install.sh | sh
345345
uv venv
346346
source .venv/bin/activate
347-
uv sync
347+
uv sync --extra dev_build
348348
cd ..
349349
if [ "${CIRCLE_BRANCH}" != "doc-prod" ]; then
350350
uv pip uninstall plotly

CONTRIBUTING.md

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -176,13 +176,6 @@ See [pytest's documentation](https://docs.pytest.org/) for more details.
176176

177177
### Generating the JavaScript Bundles for Jupyter
178178

179-
To test `go.FigureWidget` locally, you'll need to generate the JavaScript bundle as follows:
180-
181-
```
182-
cd js
183-
npm install && npm run build
184-
```
185-
186179
If you make changes to any files in the `js/` directory,
187180
you must run `npm install && npm run build` in the `js/` directory to rebuild the FigureWidget and JupyterLab extension.
188181
You must then commit the build artifacts produced in `plotly/labextension`.

0 commit comments

Comments
 (0)