Skip to content

Commit 28340d4

Browse files
committed
Revert "drm/aperture: Run fbdev removal before internal helpers"
This reverts commit 84499c5.
1 parent 2afe3d2 commit 28340d4

File tree

1 file changed

+11
-15
lines changed

1 file changed

+11
-15
lines changed

drivers/gpu/drm/drm_aperture.c

Lines changed: 11 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -329,20 +329,7 @@ int drm_aperture_remove_conflicting_pci_framebuffers(struct pci_dev *pdev,
329329
const struct drm_driver *req_driver)
330330
{
331331
resource_size_t base, size;
332-
int bar, ret;
333-
334-
/*
335-
* WARNING: Apparently we must kick fbdev drivers before vgacon,
336-
* otherwise the vga fbdev driver falls over.
337-
*/
338-
#if IS_REACHABLE(CONFIG_FB)
339-
ret = remove_conflicting_pci_framebuffers(pdev, req_driver->name);
340-
if (ret)
341-
return ret;
342-
#endif
343-
ret = vga_remove_vgacon(pdev);
344-
if (ret)
345-
return ret;
332+
int bar, ret = 0;
346333

347334
for (bar = 0; bar < PCI_STD_NUM_BARS; ++bar) {
348335
if (!(pci_resource_flags(pdev, bar) & IORESOURCE_MEM))
@@ -352,6 +339,15 @@ int drm_aperture_remove_conflicting_pci_framebuffers(struct pci_dev *pdev,
352339
drm_aperture_detach_drivers(base, size);
353340
}
354341

355-
return 0;
342+
/*
343+
* WARNING: Apparently we must kick fbdev drivers before vgacon,
344+
* otherwise the vga fbdev driver falls over.
345+
*/
346+
#if IS_REACHABLE(CONFIG_FB)
347+
ret = remove_conflicting_pci_framebuffers(pdev, req_driver->name);
348+
#endif
349+
if (ret == 0)
350+
ret = vga_remove_vgacon(pdev);
351+
return ret;
356352
}
357353
EXPORT_SYMBOL(drm_aperture_remove_conflicting_pci_framebuffers);

0 commit comments

Comments
 (0)