Skip to content

Commit 6ca7217

Browse files
committed
drm/i915/gt: Delay execlist processing for tgl
When running gem_exec_nop, it floods the system with many requests (with the goal of userspace submitting faster than the HW can process a single empty batch). This causes the driver to continually resubmit new requests onto the end of an active context, a flood of lite-restore preemptions. If we time this just right, Tigerlake hangs. Inserting a small delay between the processing of CS events and submitting the next context, prevents the hang. Naturally it does not occur with debugging enabled. The suspicion then is that this is related to the issues with the CS event buffer, and inserting an mmio read of the CS pointer status appears to be very successful in preventing the hang. Other registers, or uncached reads, or plain mb, do not prevent the hang, suggesting that register is key -- but that the hang can be prevented by a simple udelay, suggests it is just a timing issue like that encountered by commit 233c1ae ("drm/i915/gt: Wait for CSB entries on Tigerlake"). Also note that the hang is not prevented by applying CTX_DESC_FORCE_RESTORE, or by inserting a delay on the GPU between requests. Signed-off-by: Chris Wilson <[email protected]> Cc: Mika Kuoppala <[email protected]> Cc: Bruce Chang <[email protected]> Cc: Joonas Lahtinen <[email protected]> Cc: [email protected] Acked-by: Mika Kuoppala <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 57b2d83 commit 6ca7217

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

drivers/gpu/drm/i915/gt/intel_lrc.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2707,6 +2707,9 @@ static void process_csb(struct intel_engine_cs *engine)
27072707
smp_wmb(); /* complete the seqlock */
27082708
WRITE_ONCE(execlists->active, execlists->inflight);
27092709

2710+
/* XXX Magic delay for tgl */
2711+
ENGINE_POSTING_READ(engine, RING_CONTEXT_STATUS_PTR);
2712+
27102713
WRITE_ONCE(execlists->pending[0], NULL);
27112714
} else {
27122715
if (GEM_WARN_ON(!*execlists->active)) {

0 commit comments

Comments
 (0)