Skip to content

Commit 6db8b2f

Browse files
broccolinisoupbroccolinisoup
authored
Promote PageHeader to Beta 🎉 (#4725)
* Promote PageHeader to Beta * circular deps fix * Create nice-forks-joke.md * fix e2e tests story name * Update packages/react/src/PageHeader/PageHeader.docs.json * Update .changeset/nice-forks-joke.md * update test story names * back to Beta again
1 parent 9443f62 commit 6db8b2f

File tree

11 files changed

+77
-67
lines changed

11 files changed

+77
-67
lines changed

‎.changeset/nice-forks-joke.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@primer/react": minor
3+
---
4+
5+
PageHeader: Promote the component to Beta status and now it is available to import from "@primer/react"

‎e2e/components/PageHeader.test.ts

Lines changed: 40 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ test.describe('PageHeader', () => {
99
test.describe(theme, () => {
1010
test('default @vrt', async ({page}) => {
1111
await visit(page, {
12-
id: 'drafts-components-pageheader-examples--files-page',
12+
id: 'components-pageheader-examples--files-page',
1313
globals: {
1414
colorScheme: theme,
1515
},
@@ -21,7 +21,7 @@ test.describe('PageHeader', () => {
2121

2222
test('axe @aat', async ({page}) => {
2323
await visit(page, {
24-
id: 'drafts-components-pageheader-examples--files-page',
24+
id: 'components-pageheader-examples--files-page',
2525
globals: {
2626
colorScheme: theme,
2727
},
@@ -43,7 +43,7 @@ test.describe('PageHeader', () => {
4343
test.describe(theme, () => {
4444
test('default @vrt', async ({page}) => {
4545
await visit(page, {
46-
id: 'drafts-components-pageheader-examples--files-page-on-narrow-viewport',
46+
id: 'components-pageheader-examples--files-page-on-narrow-viewport',
4747
globals: {
4848
colorScheme: theme,
4949
},
@@ -55,7 +55,7 @@ test.describe('PageHeader', () => {
5555

5656
test('axe @aat', async ({page}) => {
5757
await visit(page, {
58-
id: 'drafts-components-pageheader-examples--files-page-on-narrow-viewport',
58+
id: 'components-pageheader-examples--files-page-on-narrow-viewport',
5959
globals: {
6060
colorScheme: theme,
6161
},
@@ -77,7 +77,7 @@ test.describe('PageHeader', () => {
7777
test.describe(theme, () => {
7878
test('default @vrt', async ({page}) => {
7979
await visit(page, {
80-
id: 'drafts-components-pageheader-examples--pull-request-page',
80+
id: 'components-pageheader-examples--pull-request-page',
8181
globals: {
8282
colorScheme: theme,
8383
},
@@ -89,7 +89,7 @@ test.describe('PageHeader', () => {
8989

9090
test('axe @aat', async ({page}) => {
9191
await visit(page, {
92-
id: 'drafts-components-pageheader-examples--pull-request-page',
92+
id: 'components-pageheader-examples--pull-request-page',
9393
globals: {
9494
colorScheme: theme,
9595
},
@@ -116,7 +116,7 @@ test.describe('PageHeader', () => {
116116
test.describe(theme, () => {
117117
test('default @vrt', async ({page}) => {
118118
await visit(page, {
119-
id: 'drafts-components-pageheader-examples--pull-request-page-on-narrow-viewport',
119+
id: 'components-pageheader-examples--pull-request-page-on-narrow-viewport',
120120
globals: {
121121
colorScheme: theme,
122122
},
@@ -130,7 +130,7 @@ test.describe('PageHeader', () => {
130130

131131
test('axe @aat', async ({page}) => {
132132
await visit(page, {
133-
id: 'drafts-components-pageheader-examples--pull-request-page-on-narrow-viewport',
133+
id: 'components-pageheader-examples--pull-request-page-on-narrow-viewport',
134134
globals: {
135135
colorScheme: theme,
136136
},
@@ -157,7 +157,7 @@ test.describe('PageHeader', () => {
157157
test.describe(theme, () => {
158158
test('default @vrt', async ({page}) => {
159159
await visit(page, {
160-
id: 'drafts-components-pageheader-examples--webhooks',
160+
id: 'components-pageheader-examples--webhooks',
161161
globals: {
162162
colorScheme: theme,
163163
},
@@ -169,7 +169,7 @@ test.describe('PageHeader', () => {
169169

170170
test('axe @aat', async ({page}) => {
171171
await visit(page, {
172-
id: 'drafts-components-pageheader-examples--webhooks',
172+
id: 'components-pageheader-examples--webhooks',
173173
globals: {
174174
colorScheme: theme,
175175
},
@@ -191,7 +191,7 @@ test.describe('PageHeader', () => {
191191
test.describe(theme, () => {
192192
test('default @vrt', async ({page}) => {
193193
await visit(page, {
194-
id: 'drafts-components-pageheader-examples--webhooks-on-narrow-viewport',
194+
id: 'components-pageheader-examples--webhooks-on-narrow-viewport',
195195
globals: {
196196
colorScheme: theme,
197197
},
@@ -203,7 +203,7 @@ test.describe('PageHeader', () => {
203203

204204
test('axe @aat', async ({page}) => {
205205
await visit(page, {
206-
id: 'drafts-components-pageheader-examples--webhooks-on-narrow-viewport',
206+
id: 'components-pageheader-examples--webhooks-on-narrow-viewport',
207207
globals: {
208208
colorScheme: theme,
209209
},
@@ -225,7 +225,7 @@ test.describe('PageHeader', () => {
225225
test.describe(theme, () => {
226226
test('default @vrt', async ({page}) => {
227227
await visit(page, {
228-
id: 'drafts-components-pageheader-examples--with-page-layout',
228+
id: 'components-pageheader-examples--with-page-layout',
229229
globals: {
230230
colorScheme: theme,
231231
},
@@ -237,7 +237,7 @@ test.describe('PageHeader', () => {
237237

238238
test('axe @aat', async ({page}) => {
239239
await visit(page, {
240-
id: 'drafts-components-pageheader-examples--with-page-layout',
240+
id: 'components-pageheader-examples--with-page-layout',
241241
globals: {
242242
colorScheme: theme,
243243
},
@@ -263,7 +263,7 @@ test.describe('PageHeader', () => {
263263
test.describe(theme, () => {
264264
test('default @vrt', async ({page}) => {
265265
await visit(page, {
266-
id: 'drafts-components-pageheader-features--has-large-title',
266+
id: 'components-pageheader-features--has-large-title',
267267
globals: {
268268
colorScheme: theme,
269269
},
@@ -275,7 +275,7 @@ test.describe('PageHeader', () => {
275275

276276
test('axe @aat', async ({page}) => {
277277
await visit(page, {
278-
id: 'drafts-components-pageheader-features--has-large-title',
278+
id: 'components-pageheader-features--has-large-title',
279279
globals: {
280280
colorScheme: theme,
281281
},
@@ -297,7 +297,7 @@ test.describe('PageHeader', () => {
297297
test.describe(theme, () => {
298298
test('default @vrt', async ({page}) => {
299299
await visit(page, {
300-
id: 'drafts-components-pageheader-features--has-title-only',
300+
id: 'components-pageheader-features--has-title-only',
301301
globals: {
302302
colorScheme: theme,
303303
},
@@ -309,7 +309,7 @@ test.describe('PageHeader', () => {
309309

310310
test('axe @aat', async ({page}) => {
311311
await visit(page, {
312-
id: 'drafts-components-pageheader-features--has-title-only',
312+
id: 'components-pageheader-features--has-title-only',
313313
globals: {
314314
colorScheme: theme,
315315
},
@@ -331,7 +331,7 @@ test.describe('PageHeader', () => {
331331
test.describe(theme, () => {
332332
test('default @vrt', async ({page}) => {
333333
await visit(page, {
334-
id: 'drafts-components-pageheader-features--with-actions',
334+
id: 'components-pageheader-features--with-actions',
335335
globals: {
336336
colorScheme: theme,
337337
},
@@ -343,7 +343,7 @@ test.describe('PageHeader', () => {
343343

344344
test('axe @aat', async ({page}) => {
345345
await visit(page, {
346-
id: 'drafts-components-pageheader-features--with-actions',
346+
id: 'components-pageheader-features--with-actions',
347347
globals: {
348348
colorScheme: theme,
349349
},
@@ -365,7 +365,7 @@ test.describe('PageHeader', () => {
365365
test.describe(theme, () => {
366366
test('default @vrt', async ({page}) => {
367367
await visit(page, {
368-
id: 'drafts-components-pageheader-features--with-actions-that-have-responsive-content',
368+
id: 'components-pageheader-features--with-actions-that-have-responsive-content',
369369
globals: {
370370
colorScheme: theme,
371371
},
@@ -379,7 +379,7 @@ test.describe('PageHeader', () => {
379379

380380
test('axe @aat', async ({page}) => {
381381
await visit(page, {
382-
id: 'drafts-components-pageheader-features--with-actions-that-have-responsive-content',
382+
id: 'components-pageheader-features--with-actions-that-have-responsive-content',
383383
globals: {
384384
colorScheme: theme,
385385
},
@@ -401,7 +401,7 @@ test.describe('PageHeader', () => {
401401
test.describe(theme, () => {
402402
test('default @vrt', async ({page}) => {
403403
await visit(page, {
404-
id: 'drafts-components-pageheader-features--with-context-bar-and-actions-of-context-area',
404+
id: 'components-pageheader-features--with-context-bar-and-actions-of-context-area',
405405
globals: {
406406
colorScheme: theme,
407407
},
@@ -415,7 +415,7 @@ test.describe('PageHeader', () => {
415415

416416
test('axe @aat', async ({page}) => {
417417
await visit(page, {
418-
id: 'drafts-components-pageheader-features--with-context-bar-and-actions-of-context-area',
418+
id: 'components-pageheader-features--with-context-bar-and-actions-of-context-area',
419419
globals: {
420420
colorScheme: theme,
421421
},
@@ -437,7 +437,7 @@ test.describe('PageHeader', () => {
437437
test.describe(theme, () => {
438438
test('default @vrt', async ({page}) => {
439439
await visit(page, {
440-
id: 'drafts-components-pageheader-features--with-custom-navigation',
440+
id: 'components-pageheader-features--with-custom-navigation',
441441
globals: {
442442
colorScheme: theme,
443443
},
@@ -449,7 +449,7 @@ test.describe('PageHeader', () => {
449449

450450
test('axe @aat', async ({page}) => {
451451
await visit(page, {
452-
id: 'drafts-components-pageheader-features--with-custom-navigation',
452+
id: 'components-pageheader-features--with-custom-navigation',
453453
globals: {
454454
colorScheme: theme,
455455
},
@@ -471,7 +471,7 @@ test.describe('PageHeader', () => {
471471
test.describe(theme, () => {
472472
test('default @vrt', async ({page}) => {
473473
await visit(page, {
474-
id: 'drafts-components-pageheader-features--with-description-slot',
474+
id: 'components-pageheader-features--with-description-slot',
475475
globals: {
476476
colorScheme: theme,
477477
},
@@ -483,7 +483,7 @@ test.describe('PageHeader', () => {
483483

484484
test('axe @aat', async ({page}) => {
485485
await visit(page, {
486-
id: 'drafts-components-pageheader-features--with-description-slot',
486+
id: 'components-pageheader-features--with-description-slot',
487487
globals: {
488488
colorScheme: theme,
489489
},
@@ -505,7 +505,7 @@ test.describe('PageHeader', () => {
505505
test.describe(theme, () => {
506506
test('default @vrt', async ({page}) => {
507507
await visit(page, {
508-
id: 'drafts-components-pageheader-features--with-leading-and-trailing-actions',
508+
id: 'components-pageheader-features--with-leading-and-trailing-actions',
509509
globals: {
510510
colorScheme: theme,
511511
},
@@ -517,7 +517,7 @@ test.describe('PageHeader', () => {
517517

518518
test('axe @aat', async ({page}) => {
519519
await visit(page, {
520-
id: 'drafts-components-pageheader-features--with-leading-and-trailing-actions',
520+
id: 'components-pageheader-features--with-leading-and-trailing-actions',
521521
globals: {
522522
colorScheme: theme,
523523
},
@@ -539,7 +539,7 @@ test.describe('PageHeader', () => {
539539
test.describe(theme, () => {
540540
test('default @vrt', async ({page}) => {
541541
await visit(page, {
542-
id: 'drafts-components-pageheader-features--with-leading-and-trailing-visuals',
542+
id: 'components-pageheader-features--with-leading-and-trailing-visuals',
543543
globals: {
544544
colorScheme: theme,
545545
},
@@ -551,7 +551,7 @@ test.describe('PageHeader', () => {
551551

552552
test('axe @aat', async ({page}) => {
553553
await visit(page, {
554-
id: 'drafts-components-pageheader-features--with-leading-and-trailing-visuals',
554+
id: 'components-pageheader-features--with-leading-and-trailing-visuals',
555555
globals: {
556556
colorScheme: theme,
557557
},
@@ -573,7 +573,7 @@ test.describe('PageHeader', () => {
573573
test.describe(theme, () => {
574574
test('default @vrt', async ({page}) => {
575575
await visit(page, {
576-
id: 'drafts-components-pageheader-features--with-leading-visual-hidden-on-regular-viewport',
576+
id: 'components-pageheader-features--with-leading-visual-hidden-on-regular-viewport',
577577
globals: {
578578
colorScheme: theme,
579579
},
@@ -587,7 +587,7 @@ test.describe('PageHeader', () => {
587587

588588
test('axe @aat', async ({page}) => {
589589
await visit(page, {
590-
id: 'drafts-components-pageheader-features--with-leading-visual-hidden-on-regular-viewport',
590+
id: 'components-pageheader-features--with-leading-visual-hidden-on-regular-viewport',
591591
globals: {
592592
colorScheme: theme,
593593
},
@@ -609,7 +609,7 @@ test.describe('PageHeader', () => {
609609
test.describe(theme, () => {
610610
test('default @vrt', async ({page}) => {
611611
await visit(page, {
612-
id: 'drafts-components-pageheader-features--with-navigation-slot',
612+
id: 'components-pageheader-features--with-navigation-slot',
613613
globals: {
614614
colorScheme: theme,
615615
},
@@ -621,7 +621,7 @@ test.describe('PageHeader', () => {
621621

622622
test('axe @aat', async ({page}) => {
623623
await visit(page, {
624-
id: 'drafts-components-pageheader-features--with-navigation-slot',
624+
id: 'components-pageheader-features--with-navigation-slot',
625625
globals: {
626626
colorScheme: theme,
627627
},
@@ -643,7 +643,7 @@ test.describe('PageHeader', () => {
643643
test.describe(theme, () => {
644644
test('default @vrt', async ({page}) => {
645645
await visit(page, {
646-
id: 'drafts-components-pageheader-features--with-parent-link-and-actions-of-context-area',
646+
id: 'components-pageheader-features--with-parent-link-and-actions-of-context-area',
647647
globals: {
648648
colorScheme: theme,
649649
},
@@ -657,7 +657,7 @@ test.describe('PageHeader', () => {
657657

658658
test('axe @aat', async ({page}) => {
659659
await visit(page, {
660-
id: 'drafts-components-pageheader-features--with-parent-link-and-actions-of-context-area',
660+
id: 'components-pageheader-features--with-parent-link-and-actions-of-context-area',
661661
globals: {
662662
colorScheme: theme,
663663
},
@@ -679,7 +679,7 @@ test.describe('PageHeader', () => {
679679
test.describe(theme, () => {
680680
test('default @vrt', async ({page}) => {
681681
await visit(page, {
682-
id: 'drafts-components-pageheader-devonly--large-variant-with-multiline-title',
682+
id: 'components-pageheader-devonly--large-variant-with-multiline-title',
683683
globals: {
684684
colorScheme: theme,
685685
},
@@ -691,7 +691,7 @@ test.describe('PageHeader', () => {
691691

692692
test('axe @aat', async ({page}) => {
693693
await visit(page, {
694-
id: 'drafts-components-pageheader-devonly--large-variant-with-multiline-title',
694+
id: 'components-pageheader-devonly--large-variant-with-multiline-title',
695695
globals: {
696696
colorScheme: theme,
697697
},

‎packages/react/src/PageHeader/PageHeader.dev.stories.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import {GitBranchIcon, PencilIcon, SidebarExpandIcon} from '@primer/octicons-rea
77
import {PageHeader} from './PageHeader'
88

99
const meta: Meta<typeof PageHeader> = {
10-
title: 'Drafts/Components/PageHeader/DevOnly',
10+
title: 'Components/PageHeader/DevOnly',
1111
parameters: {
1212
layout: 'fullscreen',
1313
controls: {expanded: true},

‎packages/react/src/PageHeader/PageHeader.docs.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
{
22
"id": "drafts_page_header",
33
"name": "PageHeader",
4-
"status": "draft",
4+
"status": "beta",
55
"a11yReviewed": true,
66
"stories": [],
7-
"importPath": "@primer/react/experimental",
7+
"importPath": "@primer/react",
88
"props": [
99
{
1010
"name": "aria-label",

‎packages/react/src/PageHeader/PageHeader.examples.stories.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ import {ActionMenu} from '../ActionMenu'
3737
import {ActionList} from '../ActionList'
3838

3939
const meta: Meta = {
40-
title: 'Drafts/Components/PageHeader/Examples',
40+
title: 'Components/PageHeader/Examples',
4141
parameters: {
4242
layout: 'fullscreen',
4343
controls: {expanded: true},

0 commit comments

Comments
 (0)