refactor!: transform StyleDefault into an object

`StyleDefault` was previously an enum but there is no need to enumerate the values. In addition, the values store both
number and string which is generally considered confusing and a bad practice.
Switching to a regular object make things more explicit and fix 23 SonarCloud code smells.

Author: tbouffard

src/component/mxgraph/style/utils.ts

@@ -25,45 +25,45 @@ import { BpmnStyleIdentifier } from './identifiers';
  * @category BPMN Theme
  * @experimental
  */
-export enum StyleDefault {
-  STROKE_WIDTH_THIN = 2,
-  STROKE_WIDTH_THICK = 5,
-  SHAPE_ACTIVITY_BOTTOM_MARGIN = 7,
-  SHAPE_ACTIVITY_TOP_MARGIN = 7,
-  SHAPE_ACTIVITY_LEFT_MARGIN = 7,
-  SHAPE_ACTIVITY_FROM_CENTER_MARGIN = 7,
-  SHAPE_ACTIVITY_MARKER_ICON_MARGIN = 5,
-  SHAPE_ACTIVITY_MARKER_ICON_SIZE = 20,
-  POOL_LABEL_SIZE = 30, // most of BPMN pool are ok when setting it to 30
-  POOL_LABEL_FILL_COLOR = 'none',
-  LANE_LABEL_SIZE = 30, // most of BPMN lane are ok when setting it to 30
-  LANE_LABEL_FILL_COLOR = 'none',
-  SUB_PROCESS_TRANSACTION_INNER_RECT_OFFSET = 4,
-  SUB_PROCESS_TRANSACTION_INNER_RECT_ARC_SIZE = 6,
-  TEXT_ANNOTATION_BORDER_LENGTH = 10,
-  TEXT_ANNOTATION_FILL_COLOR = 'none',
-  GROUP_FILL_COLOR = 'none',
+export const StyleDefault = {
+  STROKE_WIDTH_THIN: 2,
+  STROKE_WIDTH_THICK: 5,
+  SHAPE_ACTIVITY_BOTTOM_MARGIN: 7,
+  SHAPE_ACTIVITY_TOP_MARGIN: 7,
+  SHAPE_ACTIVITY_LEFT_MARGIN: 7,
+  SHAPE_ACTIVITY_FROM_CENTER_MARGIN: 7,
+  SHAPE_ACTIVITY_MARKER_ICON_MARGIN: 5,
+  SHAPE_ACTIVITY_MARKER_ICON_SIZE: 20,
+  POOL_LABEL_SIZE: 30, // most of BPMN pool are ok when setting it to 30
+  POOL_LABEL_FILL_COLOR: 'none',
+  LANE_LABEL_SIZE: 30, // most of BPMN lane are ok when setting it to 30
+  LANE_LABEL_FILL_COLOR: 'none',
+  SUB_PROCESS_TRANSACTION_INNER_RECT_OFFSET: 4,
+  SUB_PROCESS_TRANSACTION_INNER_RECT_ARC_SIZE: 6,
+  TEXT_ANNOTATION_BORDER_LENGTH: 10,
+  TEXT_ANNOTATION_FILL_COLOR: 'none',
+  GROUP_FILL_COLOR: 'none',
   // General
-  DEFAULT_FILL_COLOR = 'White',
-  DEFAULT_STROKE_COLOR = 'Black',
-  DEFAULT_FONT_FAMILY = 'Arial, Helvetica, sans-serif', // define our own to not depend on eventual mxGraph default change
-  DEFAULT_FONT_SIZE = 11,
-  DEFAULT_FONT_COLOR = 'Black',
-  DEFAULT_MARGIN = 0,
+  DEFAULT_FILL_COLOR: 'White',
+  DEFAULT_STROKE_COLOR: 'Black',
+  DEFAULT_FONT_FAMILY: 'Arial, Helvetica, sans-serif', // define our own to not depend on eventual mxGraph default change
+  DEFAULT_FONT_SIZE: 11,
+  DEFAULT_FONT_COLOR: 'Black',
+  DEFAULT_MARGIN: 0,
   // Shape defaults
-  SHAPE_ARC_SIZE = 20,
+  SHAPE_ARC_SIZE: 20,
   // Overlay defaults
-  DEFAULT_OVERLAY_FILL_COLOR = DEFAULT_FILL_COLOR,
-  DEFAULT_OVERLAY_FILL_OPACITY = 100,
-  DEFAULT_OVERLAY_STROKE_COLOR = DEFAULT_STROKE_COLOR,
-  DEFAULT_OVERLAY_STROKE_WIDTH = 1,
-  DEFAULT_OVERLAY_FONT_SIZE = DEFAULT_FONT_SIZE,
-  DEFAULT_OVERLAY_FONT_COLOR = DEFAULT_FONT_COLOR,
+  DEFAULT_OVERLAY_FILL_COLOR: 'White',
+  DEFAULT_OVERLAY_FILL_OPACITY: 100,
+  DEFAULT_OVERLAY_STROKE_COLOR: 'Black',
+  DEFAULT_OVERLAY_STROKE_WIDTH: 1,
+  DEFAULT_OVERLAY_FONT_SIZE: 11,
+  DEFAULT_OVERLAY_FONT_COLOR: 'Black',
   // Edge
-  SEQUENCE_FLOW_CONDITIONAL_FROM_ACTIVITY_MARKER_FILL_COLOR = 'White',
-  MESSAGE_FLOW_MARKER_START_FILL_COLOR = 'White',
-  MESSAGE_FLOW_MARKER_END_FILL_COLOR = 'White',
-}
+  SEQUENCE_FLOW_CONDITIONAL_FROM_ACTIVITY_MARKER_FILL_COLOR: 'White',
+  MESSAGE_FLOW_MARKER_START_FILL_COLOR: 'White',
+  MESSAGE_FLOW_MARKER_END_FILL_COLOR: 'White',
+};
 
 /**
  * Get the BPMN 'instantiate' information from the style.