API: Allow the Silences API to use their own 400 response (#3610)

There's no change to the logic here - it just stroke me as odd that we were reusing the response from alerting groups in the silences call when it's pretty simple to add a new one in the API description.

This is more accurate as well, as this will be used to power the documentation.

Signed-off-by: gotjosh <[email protected]>

Author: gotjosh

api/v2/api.go

@@ -511,7 +511,7 @@ func (api *API) getSilencesHandler(params silence_ops.GetSilencesParams) middlew
 			matcher, err := labels.ParseMatcher(matcherString)
 			if err != nil {
 				level.Debug(logger).Log("msg", "Failed to parse matchers", "err", err)
-				return alert_ops.NewGetAlertsBadRequest().WithPayload(err.Error())
+				return silence_ops.NewGetSilencesBadRequest().WithPayload(err.Error())
 			}
 
 			matchers = append(matchers, matcher)

api/v2/client/silence/get_silences_responses.go

@@ -53,6 +53,8 @@ paths:
           description: Get silences response
           schema:
             $ref: '#/definitions/gettableSilences'
+        '400':
+          $ref: '#/responses/BadRequest'
         '500':
           $ref: '#/responses/InternalServerError'
       parameters: