[ic] use CSA_DCHECK in CodeStubAssembler::SharedValueBarrier

Since the code is generated unconditionally, using a DCHECK to check
that shared RO heap is enabled breaks builds with
v8_enable_shared_ro_heap set to false, this patch turns that into a
CSA_DCHECK so it only crashes when V8 actually attempts to store into
a shared struct while the RO heap isn't shared at run time.

Refs: nodejs/node#42115
Bug: v8:12547
Change-Id: I30d9a02b98a0b647097125c0a9d141e40d6348cc
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3561598
Reviewed-by: Shu-yu Guo <[email protected]>
Reviewed-by: Leszek Swirski <[email protected]>
Commit-Queue: Joyee Cheung <[email protected]>
Cr-Commit-Position: refs/heads/main@{#79756}

Author: joyeecheung

src/codegen/code-stub-assembler.cc

@@ -15960,7 +15960,7 @@ void CodeStubAssembler::SharedValueBarrier(
   GotoIf(TaggedIsSmi(value), &done);
   // Fast path: Shared memory features imply shared RO space, so RO objects are
   // trivially shared.
-  DCHECK(ReadOnlyHeap::IsReadOnlySpaceShared());
+  CSA_DCHECK(this, BoolConstant(ReadOnlyHeap::IsReadOnlySpaceShared()));
   TNode<IntPtrT> page_flags = LoadBasicMemoryChunkFlags(CAST(value));
   GotoIf(WordNotEqual(WordAnd(page_flags,
                               IntPtrConstant(BasicMemoryChunk::READ_ONLY_HEAP)),