Skip to content

Commit b0aef62

Browse files
committed
Inlined any Reader/Writer#tag calls, also fixes #556
1 parent 70c9c6e commit b0aef62

26 files changed

+527
-312
lines changed

.gitignore

-1
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,4 @@
22
npm-debug.*
33
node_modules/
44
types/types.d.ts
5-
bench.txt
65
docs/

.npmignore

-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
npm-debug.*
44
node_modules/
55
types/types.d.ts
6-
bench.txt
76
docs/
87
examples/
98
src/util/aspromise/

README.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -354,11 +354,11 @@ usage: pbts [options] file1.js file2.js ...
354354

355355
### Descriptors vs. static modules
356356

357-
While .proto and JSON files require the full library (about 18kb gzipped), pretty much all code but the relatively short descriptors is shared. Hence, it usually doesn't become much larger than that.
357+
While .proto and JSON files require the full library (about 18kb gzipped, all features including reflection, parser and utility), pretty much all code but the relatively short descriptors is shared.
358358

359-
Static code, on the other hand, requires just the minimal runtime (about 5.5kb gzipped, no reflection features), but generates relatively large codebases that you can edit or strip down by hand.
359+
Static code, on the other hand, requires just the minimal runtime (about 5.5kb gzipped, i.e. no reflection features), but generates additional, albeit editable and customizable, source code.
360360

361-
When `new Function` is supported (and it usually is), there is no difference performance-wise as the code generated statically is the same as generated at runtime.
361+
When `new Function(...)` is supported (and it usually is), there is no difference performance-wise as the code generated statically is the same as generated at runtime.
362362

363363
Building
364364
--------

bench/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ var protobuf = require(".."),
2222
var root = protobuf.loadSync(require.resolve("./bench.proto"));
2323
var Test = root.lookup("Test");
2424

25-
protobuf.util.codegen.verbose = true;
25+
// protobuf.util.codegen.verbose = true;
2626

2727
var buf = Test.encode(data).finish();
2828

0 commit comments

Comments
 (0)