Handle unaggregated attestations when decomposing #15027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
force-pushed
the
minor-attestation-tweaks
branch
8 times, most recently
from
b9d57fa to
35be9d3
Compare
rkapka
force-pushed
the
minor-attestation-tweaks
branch
from
35be9d3 to
fdd5f56
Compare
nisdas
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
When decomposing block attestations in
pruneCoveredElectraAttsFromPool, there is a possibility that an aggregate has only 1 bit set, in which caseDeleteUnaggregatedAttestationshould be called on the decomposed aggregate.Acknowledgements