Do not cache slot committee aggregations for DVs #15110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
you'll need to add a changelog file for this to go through |
|
Pardon, missed that one. Should be good now. |
rkapka
approved these changes
Apr 2, 2025
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
A distributed validator expects a signature from each node's validator client and aggregates once threshold is met. For aggregations Prysm VC caches aggregations in order not to needlessly duplicate aggregation requests to the beacon node. This is only in the cases If there was already an occurrence of aggregation from another validator the Prysm VC serves.
While this works perfectly in a traditional validator setup, it causes issues for DVs. In order the DV to be able to aggregate the signatures, Prysm VC should submit signature for the same validator. Currently this is left up to the chance which would be the first validator saved and the rest are discarded from the cache.
With this change, Prysm VC will submit all aggregations for DVs, instead of just the first one it encounters.
Which issues(s) does this PR fix?
N/A
Other notes for review
N/A