Skip to content

Handle Consolidation Processing Edge Case #15122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 3, 2025
Merged

Handle Consolidation Processing Edge Case #15122

merged 3 commits into from
Apr 3, 2025

Conversation

nisdas
Copy link
Collaborator

@nisdas nisdas commented Apr 3, 2025

What type of PR is this?

Bug Fix

What does this PR do? Why is it needed?

  • In the event we have the maximum amount of consolidations included in our pending queue in the state, we will exit the consolidation processing loop. This PR makes sure that we continue processing new consolidation requests to handle new compounding consolidations.
  • Regression test

Which issues(s) does this PR fix?

N.A

Other notes for review

Acknowledgements

@nisdas nisdas added the Electra electra hardfork label Apr 3, 2025
@nisdas nisdas requested a review from a team as a code owner April 3, 2025 15:17
@nisdas nisdas requested review from kasey, terencechain and rkapka April 3, 2025 15:17
@nisdas nisdas added this pull request to the merge queue Apr 3, 2025
Merged via the queue into develop with commit 0c2464c Apr 3, 2025
17 checks passed
@nisdas nisdas deleted the cleanUpConsolidationProcessing branch April 3, 2025 16:17
This was referenced Apr 4, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestonvanloon prestonvanloon prestonvanloon approved these changes

@terencechain terencechain terencechain approved these changes

@kasey kasey Awaiting requested review from kasey kasey was automatically assigned from prysmaticlabs/core-team

@rkapka rkapka Awaiting requested review from rkapka rkapka was automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
Electra electra hardfork
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nisdas @prestonvanloon @terencechain