Use "::" to access global functions.

Author: przemek83

src/Export/ExportImage.cpp

@@ -36,7 +36,7 @@ void exportTwinImage(const QList<PlotBase*>& plotsList,
     const QSize rightSize{rightPlot->size()};
 
     const QSize imageSize(leftSize.width() + rightSize.width(),
-                          qMax(leftSize.height(), rightSize.height()));
+                          ::qMax(leftSize.height(), rightSize.height()));
     QImage image(createImage(imageSize));
     QPainter painter(&image);
 

src/ModelsAndViews/PlotDataProvider.cpp

@@ -15,7 +15,7 @@ void PlotDataProvider::recompute(QVector<TransactionData> newCalcData,
 
     QVector<double> yAxisValues;
     yAxisValues.reserve(points.size());
-    for (const auto& point : qAsConst(points))
+    for (const auto& point : ::qAsConst(points))
         yAxisValues.append(point.y());
 
     Q_EMIT basicPlotDataChanged(std::move(points), quantiles_,

src/Update/Update.cpp

@@ -259,7 +259,7 @@ void Update::finalizeUpdate()
     insertNewSectionIntoDetails(tr("Renaming temporary filenames") +
                                 QLatin1Char(':'));
 
-    for (const QString& tempFileName : qAsConst(tempFiles_))
+    for (const QString& tempFileName : ::qAsConst(tempFiles_))
         renameTempFile(tempFileName);
 
     insertNewLineIntoDetails();

src/Update/main.cpp

@@ -8,15 +8,17 @@
 
 #include "Update.h"
 
-static void showDifferentInstanceRunnningError()
+namespace
+{
+void showDifferentInstanceRunnningError()
 {
     QMessageBox::critical(nullptr, QObject::tr("Error"),
                           QObject::tr("Different instance of ") +
                               QApplication::applicationName() +
                               QObject::tr(" already running, exiting."));
 }
 
-static bool isUniqueInstance()
+bool isUniqueInstance()
 {
     // Only one instance can run. Intentionally leak.
     auto* sharedMemory{new QSharedMemory(QStringLiteral(VER_PRODUCTNAME_STR))};
@@ -49,6 +51,7 @@ static bool isUniqueInstance()
 
     return true;
 }
+}  // namespace
 
 int main(int argc, char* argv[])
 {

src/Volbx/main.cpp

@@ -9,7 +9,9 @@
 
 #include "VolbxProperties.h"
 
-static void overwriteUpdaterfIfNeeded()
+namespace
+{
+void overwriteUpdaterfIfNeeded()
 {
     const QString updaterFile{QCoreApplication::applicationDirPath() + "/" +
                               constants::getUpdaterName() +
@@ -26,6 +28,7 @@ static void overwriteUpdaterfIfNeeded()
                       updaterFile);
     }
 }
+}  // namespace
 
 int main(int argc, char* argv[])
 {