Skip to content

R10K "does not return true" error for any git-sourced module in Puppetfile #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akomakom opened this issue Dec 12, 2024 · 0 comments

Comments

@akomakom
Copy link

akomakom commented Dec 12, 2024

Describe the Bug

R10K documentation indicates that it is possible to specify git coordinates in the Puppetfile for each module. However, when attempting this, an error occurs and git checkout does not happen.

Expected Behavior

r10k should pull the requested git ref for the module

Steps to Reproduce

Steps to reproduce the behavior:

  1. Install r10k as per documentation
  2. Create a Puppetfile, eg:
# I know that this is redundant, but it also doesn't work with forks
mod 'puppetlabs-java',
    :git => 'https://github.com/puppetlabs/puppetlabs-java.git'
    :branch => 'main'

or

# Specifying a hash also does not work
mod 'puppetlabs-java',
    :git => 'https://github.com/puppetlabs/puppetlabs-java.git'
    :commit => '9255a978bc362f21654b9f9edd9d3d94002208f8'  # Also does not work
  1. r10k puppetfile install
    ERROR -> :branch: "main" === :branch does not return true
    or
    ERROR -> :commit: "9255a978bc362f21654b9f9edd9d3d94002208f8" === :commit does not return true

Environment

  • r10k Version: tested with 5.0.0, 4.1.0 (installed at /opt/puppetlabs/puppet/bin)
  • Platform: Redhat 9.4
  • Puppet 8.10.0

Additional Context

@akomakom akomakom changed the title R10K "does not return true" error if module specifies branch or commit R10K "does not return true" error for any git-sourced module in Puppetfile Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant