(maint) Update gems as far as possible

This commit updates all of our gem dependencies to latest versions
whenever possible, and as new as possible to avoid dependency resolution
conflicts besides that. This list plays nicely together.

It also removes a few puppet-lint plugins that have since been included
in puppet-lint itself. This update required a couple of test changes:

* When the `legacy_facts` plugin was incorporated into core puppet-lint,
they changed the message it emits when a legacy fact is detected to
include the name of the fact. This commit updates the test to match the
new message.
* There was also a new check added that ensures there is only a single
space before an arrow `=>` when there is only a single parameter in a
resource. We had a resource with a second param commented out, where we
never adjusted the spacing for the one that was left. This now failed
the linter, so this commit updates the spacing to make it happy, since
that was in the `goodsyntax` test.

Author: Magisus

Gemfile

@@ -1,30 +1,27 @@
 source 'https://rubygems.org'
 
-gem 'puppet',                                                    '~> 8.4'
+gem 'puppet',                                                    '~> 8.10'
 gem 'onceover',                                                  '~> 3.22'
-gem 'ffi',                                                       '~> 1.12', '>= 1.12.2'
-gem 'hiera-eyaml',                                               '~> 3.2', '>= 3.2.1'
-gem 'json',                                                      '~> 2.3'
-gem 'nokogiri',                                                  '~> 1.10', '>= 1.10.9'
-gem 'onceover-codequality',                                      '~> 0.8', '>= 0.8.0'
+gem 'ffi',                                                       '~> 1.17'
+gem 'hiera-eyaml',                                               '~> 4.0'
+gem 'json',                                                      '~> 2.12'
+gem 'nokogiri',                                                  '~> 1.18'
+gem 'onceover-codequality',                                      '~> 0.13'
 gem 'onceover-octocatalog-diff',                                 '~> 0.1', '>= 0.1.8'
 gem 'onceover-lookup',                                           '~> 0.1', '>= 0.1.1'
-gem 'parallel',                                                  '~> 1.20', '>= 1.20.1'               
-gem 'puppet-lint-classes_and_types_beginning_with_digits-check', '~> 1.0'
-gem 'puppet-lint-leading_zero-check',                            '~> 1.0'
-gem 'puppet-lint-legacy_facts-check',                            '~> 1.0', '>= 1.0.4'
-gem 'puppet-lint-top_scope_facts-check',                         '~> 1.0'
-gem 'puppet-lint-trailing_comma-check',                          '~> 0.4.1'
-gem 'puppet-lint-unquoted_string-check',                         '~> 2.0'
-gem 'puppet-lint-variable_contains_upcase',                      '~> 1.2'
-gem 'puppet-lint-version_comparison-check',                      '~> 1.0'
-gem 'puppet-lint',                                               '~> 2.4'
-gem 'puppet-strings',                                            '~> 2.6'
-gem 'puppet-syntax',                                             '~> 3.2.0'
-gem 'puppetlabs_spec_helper',                                    '~> 5.0'
-gem 'r10k',                                                      '~> 3.8'
-gem 'ra10ke',                                                    '~> 1.0'
-gem 'rspec-puppet',                                              '~> 2.12.0'
-gem 'rubocop',                                                   '~> 1.12'
-gem 'unf_ext',                                                   '~> 0.0.8'
+gem 'parallel',                                                  '~> 1.20', '>= 1.20.1'
+gem 'puppet-lint-leading_zero-check',                            '~> 2.0'
+gem 'puppet-lint-trailing_comma-check',                          '~> 2.0'
+gem 'puppet-lint-unquoted_string-check',                         '~> 3.0'
+gem 'puppet-lint-variable_contains_upcase',                      '~> 2.0'
+gem 'puppet-lint-version_comparison-check',                      '~> 2.0'
+gem 'puppet-lint',                                               '~> 4.0'
+gem 'puppet-strings',                                            '~> 4.0'
+gem 'puppet-syntax',                                             '~> 4.0'
+gem 'puppetlabs_spec_helper',                                    '~> 8.0'
+gem 'r10k',                                                      '~> 5.0'
+gem 'ra10ke',                                                    '~> 4.0'
+gem 'rspec-puppet',                                              '~> 5.0'
+gem 'rubocop',                                                   '~> 1.75'
+gem 'unf_ext',                                                   '~> 0.0.9'
 gem 'yamllint',                                                  '~> 0.0.9'

tests/control-repo/goodsyntax/manifests/site.pp

@@ -18,7 +18,7 @@
 
 # Define filebucket 'main':
 filebucket { 'main':
-  path   => false,
+  path => false,
   #server => $::puppet_server,
 }
 

tests/run_tests.sh

@@ -18,7 +18,7 @@ function runtest() {
 
   output=$($cmd 2>&1)
   exitcode=$?
-  
+
   if [ "$greptext" != "" ]; then
     echo -e $output | grep -q "$greptext"
 
@@ -56,7 +56,7 @@ runtest 'Manifests with good syntax' "docker run -v `pwd`/control-repo/goodsynta
 runtest 'Hiera with bad syntax' "docker run -v `pwd`/control-repo/badsyntax:/repo ${DOCKER_IMAGE} rake -f /Rakefile syntax:hiera" 1 "ERROR: Failed to parse data/common.yaml: (data/common.yaml): could not find expected ':' while scanning a simple key at line 4 column 1";
 runtest 'Hiera with good syntax' "docker run -v `pwd`/control-repo/goodsyntax:/repo ${DOCKER_IMAGE} rake -f /Rakefile syntax:hiera" 0 '';
 
-runtest 'Linting check catches errors' "docker run -v `pwd`/control-repo/badsyntax:/repo ${DOCKER_IMAGE} rake -f /Rakefile lint syntax yamllint" 1 'site/profile/manifests/common.pp - WARNING: legacy fact on line 5';
+runtest 'Linting check catches errors' "docker run -v `pwd`/control-repo/badsyntax:/repo ${DOCKER_IMAGE} rake -f /Rakefile lint syntax yamllint" 1 "site/profile/manifests/common.pp - WARNING: legacy fact 'osfamily' on line 5";
 runtest 'Linting check finds no errors' "docker run -v `pwd`/control-repo/goodsyntax:/repo ${DOCKER_IMAGE} rake -f /Rakefile lint syntax yamllint" 0 '';
 
 runtest 'rspec-puppet passes Deferred unwrap test' "docker run -v `pwd`/module/test:/repo ${DOCKER_IMAGE} pdk test unit --tests spec/classes/defer_spec.rb --clean-fixtures" 0