-
Notifications
You must be signed in to change notification settings - Fork 36
Two-step verification setup page was cached at cloudflare level on standard content page #794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Assuming this page should be cached, you can add a page specific option conditionally, to disable caching of the page when displaying a login page. For example: {% if isLoginPage %}
{% do craft.blitz.options.cachingEnabled(false) %}
{% endif %} See https://putyourlightson.com/plugins/blitz#page-specific-options |
Thanks for getting back, though this page was not a login page. Craft returned a completely different HTML document to what was expected in this scenario. |
In that case, you probably want to force Craft to redirect to a login page, rather than show one at |
There is not a public login page on this entire website. |
In that case, I don’t know what to recommend. This appears to be a Craft issue. |
Ok no worries, I thought maybe blitz could detect if a request was to a backend page (if this is technically classed as one) I'm not sure. I'll make an issue on their repo. |
Blitz never caches CP pages, so this must be considered a “site” page. |
sure, it's hijacked the html which should render in this case, I've opened a new issue here craftcms/cms#17129 |
Bug Report
Hey,
As the image shows, someone managed to visit a public url
/offices
which normally shows an entry's content, but what has cached at cloudflare level is the Craft Two Factor Authentication setup page.I presume this has happened where a user who has not yet setup 2fa fully tried to login, abandoned that flow (or they were previously logged in before 2FA was enabled and it was retained), then they visited an uncached page and got this, maybe because the admin bar plugin is installed on this app and that triggered the 2fa html.
Is there anything which blitz can do to handle this?
Diagnostics Report
Application Info
Installed Plugins
Loaded Modules
Blitz Plugin Settings
Recommendations
Site Tracking [1]
Site Tracking [2]
Site Tracking [4]
Site Tracking [5]
Site Tracking [6]
The text was updated successfully, but these errors were encountered: