Skip to content

Commit 53ef29b

Browse files
rwgkrwgk
committed
Systematically using --verbose for compilations where possible (cmake 3.14 or newer).
Also changing all `cmake -t` to `--target`, `-v` to `--verbose`, `check` to `pytest`, for consistency (to make it easier to pin-point all commands of a certain type). Also removing one `-j 2` for `pytest` in hopes of reducing flakes due to races in test_iostream and in prints from destructors.
1 parent 869bcc5 commit 53ef29b

File tree

1 file changed

+32
-32
lines changed

1 file changed

+32
-32
lines changed

‎.github/workflows/ci.yml

Lines changed: 32 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -106,18 +106,18 @@ jobs:
106106
${{ matrix.args }}
107107
108108
- name: Build C++11
109-
run: cmake --build . -j 2
109+
run: cmake --build . --verbose -j 2
110110

111111
- name: Python tests C++11
112-
run: cmake --build . --target pytest -j 2
112+
run: cmake --build . --target pytest
113113

114114
- name: C++11 tests
115115
# TODO: Figure out how to load the DLL on Python 3.8+
116116
if: "!(runner.os == 'Windows' && (matrix.python == 3.8 || matrix.python == 3.9 || matrix.python == '3.10-dev'))"
117-
run: cmake --build . --target cpptest -j 2
117+
run: cmake --build . --verbose --target cpptest -j 2
118118

119119
- name: Interface test C++11
120-
run: cmake --build . --target test_cmake_build
120+
run: cmake --build . --verbose --target test_cmake_build
121121

122122
- name: Clean directory
123123
run: git clean -fdx
@@ -134,18 +134,18 @@ jobs:
134134
${{ matrix.args2 }}
135135
136136
- name: Build
137-
run: cmake --build build2 -j 2
137+
run: cmake --build build2 --verbose -j 2
138138

139139
- name: Python tests
140140
run: cmake --build build2 --target pytest
141141

142142
- name: C++ tests
143143
# TODO: Figure out how to load the DLL on Python 3.8+
144144
if: "!(runner.os == 'Windows' && (matrix.python == 3.8 || matrix.python == 3.9 || matrix.python == '3.10-dev'))"
145-
run: cmake --build build2 --target cpptest
145+
run: cmake --build build2 --verbose --target cpptest
146146

147147
- name: Interface test
148-
run: cmake --build build2 --target test_cmake_build
148+
run: cmake --build build2 --verbose --target test_cmake_build
149149

150150
# Eventually Microsoft might have an action for setting up
151151
# MSVC, but for now, this action works:
@@ -234,17 +234,17 @@ jobs:
234234
-DCMAKE_CXX_STANDARD=17
235235
236236
- name: Build
237-
run: cmake --build build -j 2
237+
run: cmake --build build --verbose -j 2
238238

239239
- name: Python tests
240240
run: cmake --build build --target pytest
241241

242242
- name: C++ tests
243-
run: cmake --build build --target cpptest
243+
run: cmake --build build --verbose --target cpptest
244244

245245
- name: Run Valgrind on Python tests
246246
if: matrix.valgrind
247-
run: cmake --build build --target memcheck
247+
run: cmake --build build --verbose --target memcheck
248248

249249

250250
# Testing on clang using the excellent silkeh clang docker images
@@ -318,7 +318,7 @@ jobs:
318318
run: cmake -S . -B build -DPYBIND11_CUDA_TESTS=ON -DPYBIND11_WERROR=ON -DDOWNLOAD_CATCH=ON
319319

320320
- name: Build
321-
run: cmake --build build -j2 --verbose
321+
run: cmake --build build --verbose -j2
322322

323323
- name: Python tests
324324
run: cmake --build build --target pytest
@@ -400,7 +400,7 @@ jobs:
400400
401401
# Building before installing Pip should produce a warning but not an error
402402
- name: Build
403-
run: cmake3 --build build -j 2 --verbose
403+
run: cmake3 --build build -j 2
404404

405405
- name: Install CMake with pip
406406
run: |
@@ -457,16 +457,16 @@ jobs:
457457
-DPYTHON_EXECUTABLE=$(python3 -c "import sys; print(sys.executable)")
458458
459459
- name: Build
460-
run: cmake --build build -j 2
460+
run: cmake --build build --verbose -j 2
461461

462462
- name: Python tests
463463
run: cmake --build build --target pytest
464464

465465
- name: C++ tests
466-
run: cmake --build build --target cpptest
466+
run: cmake --build build --verbose --target cpptest
467467

468468
- name: Interface test
469-
run: cmake --build build --target test_cmake_build
469+
run: cmake --build build --verbose --target test_cmake_build
470470

471471

472472
# Testing on ICC using the oneAPI apt repo
@@ -515,23 +515,23 @@ jobs:
515515
- name: Build C++11
516516
run: |
517517
set +e; source /opt/intel/oneapi/setvars.sh; set -e
518-
cmake --build build-11 -j 2 -v
518+
cmake --build build-11 --verbose -j 2
519519
520520
- name: Python tests C++11
521521
run: |
522522
set +e; source /opt/intel/oneapi/setvars.sh; set -e
523523
sudo service apport stop
524-
cmake --build build-11 --target check
524+
cmake --build build-11 --target pytest
525525
526526
- name: C++ tests C++11
527527
run: |
528528
set +e; source /opt/intel/oneapi/setvars.sh; set -e
529-
cmake --build build-11 --target cpptest
529+
cmake --build build-11 --verbose --target cpptest
530530
531531
- name: Interface test C++11
532532
run: |
533533
set +e; source /opt/intel/oneapi/setvars.sh; set -e
534-
cmake --build build-11 --target test_cmake_build
534+
cmake --build build-11 --verbose --target test_cmake_build
535535
536536
- name: Configure C++17
537537
run: |
@@ -547,23 +547,23 @@ jobs:
547547
- name: Build C++17
548548
run: |
549549
set +e; source /opt/intel/oneapi/setvars.sh; set -e
550-
cmake --build build-17 -j 2 -v
550+
cmake --build build-17 --verbose -j 2
551551
552552
- name: Python tests C++17
553553
run: |
554554
set +e; source /opt/intel/oneapi/setvars.sh; set -e
555555
sudo service apport stop
556-
cmake --build build-17 --target check
556+
cmake --build build-17 --target pytest
557557
558558
- name: C++ tests C++17
559559
run: |
560560
set +e; source /opt/intel/oneapi/setvars.sh; set -e
561-
cmake --build build-17 --target cpptest
561+
cmake --build build-17 --verbose --target cpptest
562562
563563
- name: Interface test C++17
564564
run: |
565565
set +e; source /opt/intel/oneapi/setvars.sh; set -e
566-
cmake --build build-17 --target test_cmake_build
566+
cmake --build build-17 --verbose --target test_cmake_build
567567
568568
569569
# Testing on CentOS (manylinux uses a centos base, and this is an easy way
@@ -614,16 +614,16 @@ jobs:
614614
-DPYTHON_EXECUTABLE=$(python3 -c "import sys; print(sys.executable)")
615615
616616
- name: Build
617-
run: cmake --build build -j 2
617+
run: cmake --build build --verbose -j 2
618618

619619
- name: Python tests
620620
run: cmake --build build --target pytest
621621

622622
- name: C++ tests
623-
run: cmake --build build --target cpptest
623+
run: cmake --build build --verbose --target cpptest
624624

625625
- name: Interface test
626-
run: cmake --build build --target test_cmake_build
626+
run: cmake --build build --verbose --target test_cmake_build
627627

628628

629629
# This tests an "install" with the CMake tools
@@ -758,7 +758,7 @@ jobs:
758758
-DDOWNLOAD_EIGEN=ON
759759
${{ matrix.args }}
760760
- name: Build C++11
761-
run: cmake --build build -j 2
761+
run: cmake --build build --verbose -j 2
762762

763763
- name: Python tests
764764
run: cmake --build build -t pytest
@@ -804,10 +804,10 @@ jobs:
804804
-DDOWNLOAD_EIGEN=ON
805805
806806
- name: Build C++14
807-
run: cmake --build build -j 2
807+
run: cmake --build build --verbose -j 2
808808

809809
- name: Run all checks
810-
run: cmake --build build -t check
810+
run: cmake --build build --target pytest
811811

812812

813813
win32-msvc2017:
@@ -855,10 +855,10 @@ jobs:
855855
${{ matrix.args }}
856856
857857
- name: Build ${{ matrix.std }}
858-
run: cmake --build build -j 2
858+
run: cmake --build build --verbose -j 2
859859

860860
- name: Run all checks
861-
run: cmake --build build -t check
861+
run: cmake --build build --target pytest
862862

863863
mingw:
864864
runs-on: windows-latest
@@ -886,7 +886,7 @@ jobs:
886886
run: cmake -G "MinGW Makefiles" -S . -B build
887887

888888
- name: Build
889-
run: cmake --build build -j 2
889+
run: cmake --build build --verbose -j 2
890890

891891
- name: Python tests
892892
run: cmake --build build --target pytest

0 commit comments

Comments
 (0)