Skip to content

Commit 6b035b7

Browse files
committed
Default run.shell to /bin/sh
`/bin/bash` is not availabe on some popular distributions, for example NixOS. Defaulting to the more conservative `/bin/sh` improves portability.
1 parent ee9d862 commit 6b035b7

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

invoke/config.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -445,11 +445,11 @@ def global_defaults() -> Dict[str, Any]:
445445
# unqualified cmd.exe otherwise.
446446
if WINDOWS:
447447
shell = os.environ.get("COMSPEC", "cmd.exe")
448-
# Else, assume Unix, most distros of which have /bin/bash available.
449-
# TODO: consider an automatic fallback to /bin/sh for systems lacking
450-
# /bin/bash; however users may configure run.shell quite easily, so...
448+
# Else, assume a POSIX compatible Unix, where /bin/sh is mandated by
449+
# the standard. Users on more exotic platforms are expected to configure
450+
# run.shell manually.
451451
else:
452-
shell = "/bin/bash"
452+
shell = "/bin/sh"
453453

454454
return {
455455
# TODO: we document 'debug' but it's not truly implemented outside

0 commit comments

Comments
 (0)