Skip to content

Consider removing test_distributions.py from arviz-compatibility workflow #5410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ricardoV94 opened this issue Jan 27, 2022 · 5 comments · Fixed by #5472
Closed

Consider removing test_distributions.py from arviz-compatibility workflow #5410

ricardoV94 opened this issue Jan 27, 2022 · 5 comments · Fixed by #5472

Comments

@ricardoV94
Copy link
Member

ricardoV94 commented Jan 27, 2022

This job usually takes more than 45-50 minutes in MacOS, while all others jobs (Ubuntu/Windows/MacOs) take less than 30 minutes, so we end up in fact always waiting for this one. This divergence is pretty clear here:

image

Blue: arviz-compatibility.yml
Orange: pytest.yml (includes all tests in arviz-compatibility.yml and more)

Obtained from https://share.streamlit.io/koaning/gitlit/main

We could consider replacing this test by something else, perhaps a more CI-like suite of tests as opposed to this number crunching one, which is already covered in pytest.yml (Ubuntu 18.04 only).

@ricardoV94 ricardoV94 changed the title Remove test_distributions.py from arviz-compatibility workflow Consider removing test_distributions.py from arviz-compatibility workflow Jan 27, 2022
@parthb83
Copy link
Contributor

parthb83 commented Feb 1, 2022

Hey @ricardoV94! Do you want to remove test_distributions.py only from the macOS-latest workflow or from the ubuntu-latest workflow as well in arviz_compat.yml?

@ricardoV94
Copy link
Member Author

We could remove from both, but more importantly we should think what tests to use instead

@parthb83
Copy link
Contributor

parthb83 commented Feb 1, 2022

So should we create a new test or replace it with an existing one? If we replace it with an existing one, which test/set of tests would be better according to you?

@michaelosthege
Copy link
Member

There are good reasons to combine all workflows into one (#5041) and then we could easily shift tests around to reduce wall-clock runtime.
For test_distributions.py in particular I think it should be split up into 2-3 parts. Then we could run parts on different operating systems.

@ricardoV94
Copy link
Member Author

We could split the distribution tests according to their modules: discrete, continuous, multivariate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants