Add support for action of type message_action (#40)

Author: ovv

README.rst

@@ -73,6 +73,12 @@ Changelog
 dev
 ```
 
+0.4.2
+`````
+
+* Support incoming action of type ``message_action``
+
+
 0.4.1
 `````
 

slack/__version__.py

@@ -1,3 +1,3 @@
 # Version information
 
-__version__ = "0.4.1"
+__version__ = "0.4.2"

slack/actions.py

@@ -9,7 +9,7 @@
 
 class Action(MutableMapping):
     """
-    MutableMapping representing a response to an interactive message.
+    MutableMapping representing a response to an interactive message, a dialog submission or a message action.
 
     Args:
         raw_action: Decoded body of the HTTP request
@@ -99,12 +99,12 @@ def dispatch(self, action):
 
         if action["type"] == "interactive_message":
             yield from self._dispatch_interactive_message(action)
-        elif action["type"] == "dialog_submission":
-            yield from self._dispatch_dialog_submission(action)
+        elif action["type"] in ("dialog_submission", "message_action"):
+            yield from self._dispatch_action(action)
         else:
             raise exceptions.UnknownActionType(action)
 
-    def _dispatch_dialog_submission(self, action):
+    def _dispatch_action(self, action):
         yield from self._routes[action["callback_id"]].get("*", [])
 
     def _dispatch_interactive_message(self, action):

slack/tests/conftest.py

@@ -174,7 +174,11 @@ def message_router():
 
 
 @pytest.fixture(
-    params={**data.InteractiveMessage.__members__, **data.DialogSubmission.__members__}
+    params={
+        **data.InteractiveMessage.__members__,
+        **data.DialogSubmission.__members__,
+        **data.MessageAction.__members__,
+    }
 )
 def action(request):
     return Action.from_http(raw_action(request))
@@ -190,15 +194,31 @@ def dialog_submission(request):
     return Action.from_http(raw_action(request))
 
 
+@pytest.fixture(params={**data.MessageAction.__members__})
+def message_action(request):
+    return Action.from_http(raw_action(request))
+
+
 @pytest.fixture(
-    params={**data.InteractiveMessage.__members__, **data.DialogSubmission.__members__}
+    params={
+        **data.InteractiveMessage.__members__,
+        **data.DialogSubmission.__members__,
+        **data.MessageAction.__members__,
+    }
 )
 def raw_action(request):
     if isinstance(request.param, str):
         try:
             return copy.deepcopy(data.InteractiveMessage[request.param].value)
         except KeyError:
+            pass
+
+        try:
             return copy.deepcopy(data.DialogSubmission[request.param].value)
+        except KeyError:
+            pass
+
+        return copy.deepcopy(data.MessageAction[request.param].value)
     else:
         return copy.deepcopy(request.param)
 

slack/tests/data/__init__.py

@@ -1,4 +1,4 @@
 from .events import Events, Messages, RTMEvents  # noQa F401
-from .actions import DialogSubmission, InteractiveMessage  # noQa F401
+from .actions import MessageAction, DialogSubmission, InteractiveMessage  # noQa F401
 from .methods import Methods  # noQa F401
 from .commands import Commands  # noQa F401

slack/tests/data/actions.py

@@ -45,9 +45,30 @@
     "response_url": "https://hooks.slack.com/actions/T000AAA0A/123456789123/YTC81HsJRuuGSLVFbSnlkJlh",
 }
 
+message_action = {
+    "type": "message_action",
+    "token": "supersecuretoken",
+    "action_ts": "987654321.000001",
+    "team": {"id": "T000AAA0A", "domain": "team"},
+    "user": {"id": "U000AA000", "name": "username"},
+    "channel": {"id": "C00000A00", "name": "general"},
+    "callback_id": "test_action",
+    "trigger_id": "418799722116.77329528181.9c7441638716b0b9b698f3d8ae73d9c1",
+    "message_ts": "1534605601.000100",
+    "message": {
+        "type": "message",
+        "user": "U000AA000",
+        "text": "test message",
+        "client_msg_id": "904f281d-338e-4621-a56f-afbfc80b3c59",
+        "ts": "1534605601.000100",
+    },
+    "response_url": "https://hooks.slack.com/actions/T000AAA0A/123456789123/YTC81HsJRuuGSLVFbSnlkJlh",
+}
+
 raw_button_ok = {"payload": json.dumps(button_ok)}
 raw_button_cancel = {"payload": json.dumps(button_cancel)}
 raw_dialog_submission = {"payload": json.dumps(dialog_submission)}
+raw_message_action = {"payload": json.dumps(message_action)}
 
 
 class InteractiveMessage(Enum):
@@ -72,3 +93,13 @@ class DialogSubmission(Enum):
     """
 
     dialog_submission = raw_dialog_submission
+
+
+class MessageAction(Enum):
+    """
+    List of available message action submission for testing
+
+        - action
+    """
+
+    action = raw_message_action