Skip to content

Commit 6630551

Browse files
authored
Merge pull request #126 from stlehmann/altendky-patch-3
QtCore.QCoreApplication.instance() may return None
2 parents e9a2f2d + fd2e1e6 commit 6630551

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
1616
* [#51](https://github.com/stlehmann/PyQt5-stubs/pull/51) adds `pyqtBoundSignal.signal` hinted as `str`
1717

1818
### Changed
19+
* [#126](https://github.com/stlehmann/PyQt5-stubs/pull/126) fix `QCoreApplication.instance()` return type to be optional
1920
* [#102](https://github.com/stlehmann/PyQt5-stubs/pull/102) fix `pyqtSlot` parameter typing and overloads
2021
* [#104](https://github.com/stlehmann/PyQt5-stubs/pull/104) `sip.voidptr` handles integer values and sequences and takes `self`
2122
* [#103](https://github.com/stlehmann/PyQt5-stubs/pull/103) `pyqtBoundSignal.disconnect()`'s `slot` parameter is optional

PyQt5-stubs/QtCore.pyi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3020,7 +3020,7 @@ class QCoreApplication(QObject):
30203020
@staticmethod
30213021
def exec_() -> int: ...
30223022
@staticmethod
3023-
def instance() -> 'QCoreApplication': ...
3023+
def instance() -> typing.Optional['QCoreApplication']: ...
30243024
@staticmethod
30253025
def arguments() -> typing.List[str]: ...
30263026
@staticmethod

0 commit comments

Comments
 (0)