Merge pull request #47482 from holly-cummins/diagnostics-for-null-system-properties

Improve diagnostic output for null system properties

Author: gsmet

test-framework/common/src/main/java/io/quarkus/test/common/RestorableSystemProperties.java

@@ -20,6 +20,16 @@ public static RestorableSystemProperties setProperties(Map<String, String> props
             sysPropRestore.put(i.getKey(), System.getProperty(i.getKey()));
         }
         for (Map.Entry<String, String> i : props.entrySet()) {
+            if (i.getKey() == null) {
+                throw new IllegalArgumentException(
+                        String.format("Internal error: Cannot set null key as a system property (value is %s)",
+                                i.getValue()));
+            }
+            if (i.getValue() == null) {
+                throw new IllegalArgumentException(
+                        String.format("Internal error: Cannot use null value as a system property (key is %s)",
+                                i.getKey()));
+            }
             System.setProperty(i.getKey(), i.getValue());
         }
         return new RestorableSystemProperties(sysPropRestore);