You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: vignettes/articles/pr-functions.Rmd
+12-4
Original file line number
Diff line number
Diff line change
@@ -136,11 +136,13 @@ This creates a local branch called `formidable` and we switch to it (or "check i
136
136
Let's go ahead and make the change, which is adding the word "formidable" to the `R/adjective.R` file in the package. Below is the diff and the commit associated with this change.
137
137
138
138
```{r, echo = FALSE}
139
-
#| fig-alt: Screenshot of the RStudio Git pane showing the file
139
+
#| fig-alt: >
140
+
#| Screenshot of the RStudio Git pane showing the file
140
141
#| R/adjective.R staged for a commit. The preview of the file
141
142
#| highlights the addition of the line formidabel, with no comma
142
143
#| at the end of the line. The Commit message says
If we're lucky, and our pull request is perfect, the maintainer will accept it, a.k.a. merge it. However, in this case, the PR still needs some work. So the package maintainer leaves us comments requesting changes.
200
204
201
205
```{r, echo = FALSE}
202
-
#| fig-alt: A screenshot of the comments section on the pull request.
206
+
#| fig-alt: >
207
+
#| A screenshot of the comments section on the pull request.
203
208
#| A comment from a collaborator on the new line says Did
204
209
#| you mean to add formidable? And can you please add a comma
Being somewhat new to all this, we try to address one of these comments (fix spelling) and neglect the other (forget to add the comma). We make another change and commit it.
210
216
211
217
```{r, echo = FALSE}
212
-
#| fig-alt: A screenshot of the Rstudio Git pane, showing the changed line
218
+
#| fig-alt: >
219
+
#| A screenshot of the Rstudio Git pane, showing the changed line
213
220
#| with formidabel changed to formidable. The file R/adjective.R
214
221
#| is staged for a commit, with the commit message Fix Spelling!
0 commit comments