Add 2025 bullets for tidy upkeep (#2119)

* Add 2025 bullets for tidy upkeep

* Remove the nudge re: R minimum version from "To finish"

Currently this is redundant with the 2025 bullets

* Add the posit-dev org

Author: jennybc

R/release.R

@@ -462,7 +462,8 @@ is_posit_person_canonical <- function() {
     "fnd" %in% roles &&
     "cph" %in% roles &&
     attr(roles, "appears_in", exact = TRUE) == "given" &&
-    attr(roles, "appears_as", exact = TRUE) == "Posit Software, PBC"
+    attr(roles, "appears_as", exact = TRUE) == "Posit Software, PBC" &&
+    attr(roles, "ror", exact = TRUE) %in% "03wc8by49"
 }
 
 get_posit_roles <- function() {
@@ -493,6 +494,10 @@ get_posit_roles <- function() {
     attr(out, "appears_as") <- person$family
     attr(out, "appears_in") <- "family"
   }
+
+  comment <- person$comment %||% character()
+  attr(out, "ror") <- comment["ROR"]
+
   out
 }
 
@@ -512,7 +517,8 @@ posit_orgs <- function() {
     "tidyverse",
     "r-lib",
     "tidymodels",
-    "rstudio"
+    "rstudio",
+    "posit-dev"
   )
 }
 

R/upkeep.R

@@ -243,20 +243,53 @@ tidy_upkeep_checklist <- function(last_upkeep = last_upkeep_year(),
     )
   }
 
+  if (last_upkeep <= 2025) {
+    bullets <- c(
+      bullets,
+      "### 2025",
+      "",
+      todo("`usethis::use_air()` <https://posit-dev.github.io/air/>"),
+      todo('`usethis::use_package("R", "Depends", "4.1")`'),
+      todo("Switch to the base pipe (`|>`)"),
+      todo("Switch to the base anonymous function syntax (`\\(x)`) "),
+      todo(
+        '
+        Add ROR for Posit in `DESCRIPTION`:
+        `person("Posit Software, PBC", role = c("cph", "fnd"), comment = c(ROR = "03wc8by49"))`',
+        posit_pkg && !posit_person_ok
+      ),
+      todo(
+        '
+        `knitr::convert_chunk_header(type = "yaml")` to convert in-header \\
+        chunk options to the newer in-body style used by Quarto
+        '
+      ),
+      todo(
+        "Switch to `expect_snapshot(error = TRUE)` instead of calling `expect_error()` without specifying `class =`"
+      ),
+      ""
+    )
+  }
+
+  # if the most recent year doesn't nudge about the minimum R version,
+  # re-introduce that todo() below
   minimum_r_version <- pkg_minimum_r_version()
   bullets <- c(
     bullets,
     "### To finish",
     "",
     todo("`usethis::use_mit_license()`", grepl("MIT", desc$get_field("License"))),
-    todo(
-      '`usethis::use_package("R", "Depends", "{tidy_minimum_r_version()}")`',
-      is.na(minimum_r_version) || tidy_minimum_r_version() > minimum_r_version
-    ),
     todo("`usethis::use_tidy_description()`"),
     todo("`usethis::use_tidy_github_actions()`"),
     todo("`devtools::build_readme()`"),
-    todo("[Re-publish released site](https://pkgdown.r-lib.org/dev/articles/how-to-update-released-site.html) if needed"),
+    todo(
+      "
+      Add alt-text to pictures, plots, etc; see \\
+      https://posit.co/blog/knitr-fig-alt/ for examples"
+    ),
+    todo(
+      "[Re-publish released site](https://pkgdown.r-lib.org/dev/articles/how-to-update-released-site.html) if needed"
+    ),
     ""
   )
 

tests/testthat/_snaps/upkeep.md

@@ -49,13 +49,24 @@
       or [file an issue](new) if you don't have time to do it now
       * [ ] Add alt-text to pictures, plots, etc; see https://posit.co/blog/knitr-fig-alt/ for examples
       
+      ### 2025
+      
+      * [ ] `usethis::use_air()` <https://posit-dev.github.io/air/>
+      * [ ] `usethis::use_package("R", "Depends", "4.1")`
+      * [ ] Switch to the base pipe (`|>`)
+      * [ ] Switch to the base anonymous function syntax (`\(x)`) 
+      * [ ] Add ROR for Posit in `DESCRIPTION`:
+      `person("Posit Software, PBC", role = c("cph", "fnd"), comment = c(ROR = "03wc8by49"))`
+      * [ ] `knitr::convert_chunk_header(type = "yaml")` to convert in-header chunk options to the newer in-body style used by Quarto
+      * [ ] Switch to `expect_snapshot(error = TRUE)` instead of calling `expect_error()` without specifying `class =`
+      
       ### To finish
       
       * [ ] `usethis::use_mit_license()`
-      * [ ] `usethis::use_package("R", "Depends", "4.1")`
       * [ ] `usethis::use_tidy_description()`
       * [ ] `usethis::use_tidy_github_actions()`
       * [ ] `devtools::build_readme()`
+      * [ ] Add alt-text to pictures, plots, etc; see https://posit.co/blog/knitr-fig-alt/ for examples
       * [ ] [Re-publish released site](https://pkgdown.r-lib.org/dev/articles/how-to-update-released-site.html) if needed
       
       <sup>Created on 2025-01-01 with `usethis::use_tidy_upkeep_issue()`, using [usethis v1.1.0](https://usethis.r-lib.org)</sup>
@@ -83,13 +94,24 @@
       or [file an issue](new) if you don't have time to do it now
       * [ ] Add alt-text to pictures, plots, etc; see https://posit.co/blog/knitr-fig-alt/ for examples
       
+      ### 2025
+      
+      * [ ] `usethis::use_air()` <https://posit-dev.github.io/air/>
+      * [ ] `usethis::use_package("R", "Depends", "4.1")`
+      * [ ] Switch to the base pipe (`|>`)
+      * [ ] Switch to the base anonymous function syntax (`\(x)`) 
+      * [ ] Add ROR for Posit in `DESCRIPTION`:
+      `person("Posit Software, PBC", role = c("cph", "fnd"), comment = c(ROR = "03wc8by49"))`
+      * [ ] `knitr::convert_chunk_header(type = "yaml")` to convert in-header chunk options to the newer in-body style used by Quarto
+      * [ ] Switch to `expect_snapshot(error = TRUE)` instead of calling `expect_error()` without specifying `class =`
+      
       ### To finish
       
       * [ ] `usethis::use_mit_license()`
-      * [ ] `usethis::use_package("R", "Depends", "4.1")`
       * [ ] `usethis::use_tidy_description()`
       * [ ] `usethis::use_tidy_github_actions()`
       * [ ] `devtools::build_readme()`
+      * [ ] Add alt-text to pictures, plots, etc; see https://posit.co/blog/knitr-fig-alt/ for examples
       * [ ] [Re-publish released site](https://pkgdown.r-lib.org/dev/articles/how-to-update-released-site.html) if needed
       
       <sup>Created on 2025-01-01 with `usethis::use_tidy_upkeep_issue()`, using [usethis v1.1.0](https://usethis.r-lib.org)</sup>