Skip to content

use_package(min_version = FALSE) is not handled properly #2118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
salim-b opened this issue Apr 9, 2025 · 2 comments · May be fixed by #2117
Open

use_package(min_version = FALSE) is not handled properly #2118

salim-b opened this issue Apr 9, 2025 · 2 comments · May be fixed by #2117

Comments

@salim-b
Copy link
Contributor

salim-b commented Apr 9, 2025 

usethis::use_package(package = "usethis",
                     min_version = FALSE)

throws the following

Warning message:
'Imports' must contain valid version requirements

and writes this line to DESCRIPTION:

    usethis (>= FALSE),

while it should actually omit the version spec.
@salim-b salim-b linked a pull request Apr 9, 2025 that will close this issue
Open
@olivroy
Copy link
Contributor

olivroy commented Apr 24, 2025

it is undocumented to use ’min_version = F use_package(“usethis“) should do the trick?

@salim-b
Copy link
Contributor Author

salim-b commented Apr 24, 2025

it is undocumented to use ’min_version = F

Yup. But since TRUE is accepted, I'd also expect it handle the opposite. Makes it more friendly to script with.

use_package(“usethis“) should do the trick?

Sure, but not the point. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: properly handle use_package(min_version = FALSE) salim-b/usethis
2 participants
@salim-b @olivroy