Skip to content

Commit fa99e9c

Browse files
committed
Simplify test
1 parent d4eb583 commit fa99e9c

File tree

1 file changed

+26
-22
lines changed

1 file changed

+26
-22
lines changed

src/test/java/com/rabbitmq/client/amqp/impl/TopologyRecoveryTest.java

+26-22
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,18 @@
3939
import com.rabbitmq.client.amqp.impl.TestUtils.Sync;
4040
import java.util.List;
4141
import java.util.Set;
42-
import java.util.concurrent.*;
42+
import java.util.concurrent.ArrayBlockingQueue;
43+
import java.util.concurrent.BlockingQueue;
44+
import java.util.concurrent.ConcurrentHashMap;
45+
import java.util.concurrent.CopyOnWriteArrayList;
46+
import java.util.concurrent.CountDownLatch;
47+
import java.util.concurrent.TimeUnit;
4348
import java.util.concurrent.atomic.AtomicInteger;
4449
import java.util.stream.IntStream;
4550
import org.assertj.core.api.Assertions;
46-
import org.junit.jupiter.api.*;
51+
import org.junit.jupiter.api.BeforeEach;
52+
import org.junit.jupiter.api.Test;
53+
import org.junit.jupiter.api.TestInfo;
4754
import org.junit.jupiter.params.ParameterizedTest;
4855
import org.junit.jupiter.params.provider.ValueSource;
4956
import org.slf4j.Logger;
@@ -649,21 +656,6 @@ void shouldRecoverEvenIfManagementIsClosed(TestInfo info) {
649656
Management management = connection.management();
650657
Management.QueueInfo queueInfo = management.queue().exclusive(true).declare();
651658
String q = queueInfo.name();
652-
Publisher publisher = connection.publisherBuilder().queue(q).build();
653-
Sync publishSync = TestUtils.sync();
654-
Publisher.Callback callback =
655-
ctx -> {
656-
if (ctx.status() == ACCEPTED) {
657-
publishSync.down();
658-
} else {
659-
LOGGER.warn(
660-
"Unexpected status: {} ({})", ctx.status(), info.getTestMethod().get().getName());
661-
}
662-
};
663-
publisher.publish(publisher.message(), callback);
664-
assertThat(publishSync).completes();
665-
666-
waitAtMost(() -> management.queueInfo(q).messageCount() == 1);
667659

668660
Sync consumeSync = TestUtils.sync();
669661
connection
@@ -676,16 +668,28 @@ void shouldRecoverEvenIfManagementIsClosed(TestInfo info) {
676668
})
677669
.build();
678670

679-
assertThat(consumeSync).completes();
680-
waitAtMost(() -> management.queueInfo(q).messageCount() == 0);
681-
management.close();
671+
waitAtMost(() -> management.queueInfo(q).consumerCount() == 1);
682672

683-
publishSync.reset();
684-
consumeSync.reset();
673+
management.close();
685674

686675
closeConnectionAndWaitForRecovery();
676+
677+
Publisher publisher = connection.publisherBuilder().queue(q).build();
678+
Sync publishSync = TestUtils.sync();
679+
Publisher.Callback callback =
680+
ctx -> {
681+
if (ctx.status() == ACCEPTED) {
682+
publishSync.down();
683+
} else {
684+
LOGGER.warn(
685+
"Unexpected status: {} ({})", ctx.status(), info.getTestMethod().get().getName());
686+
}
687+
};
687688
publisher.publish(publisher.message(), callback);
689+
assertThat(publishSync).completes();
690+
688691
assertThat(consumeSync).completes();
692+
689693
assertThatThrownBy(() -> management.queueInfo(q))
690694
.isInstanceOf(AmqpResourceClosedException.class);
691695
assertThat(connection.management().queueInfo(q)).isEmpty();

0 commit comments

Comments
 (0)