Skip to content

a11y: Ensure new focus colours work well with Prime branding #13566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
richard-cox opened this issue Mar 3, 2025 · 11 comments · Fixed by #13842 or #14100
Closed

a11y: Ensure new focus colours work well with Prime branding #13566

richard-cox opened this issue Mar 3, 2025 · 11 comments · Fixed by #13842 or #14100
Assignees
Milestone

Comments

@richard-cox
Copy link
Member

richard-cox commented Mar 3, 2025

  • The new light and dark mode a11y changes bring in more pronounced focus colours
  • We need to ensure these work well with prime branding (and suse if it's still used anywhere)
@richard-cox richard-cox added this to the v2.11.1 milestone Mar 3, 2025
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Mar 3, 2025
@gaktive gaktive added status/dev-validate QA/manual-test Indicates issue requires manually testing and removed QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels Mar 12, 2025
@gaktive
Copy link
Member

gaktive commented Mar 12, 2025

Before passing to QA, let's spin up an instance and get a screenshot with prime branding and run it by UX.

@gaktive gaktive added the size/0.5 Size Estimate 0.5 label Mar 12, 2025
@rak-phillip rak-phillip modified the milestones: v2.11.1, v2.12.0 Mar 20, 2025
@rak-phillip
Copy link
Member

/backport v2.11.1

@rak-phillip
Copy link
Member

Reopening this issue because it didn't get picked up by automation. This should get closed after it passes QA.

@rak-phillip rak-phillip reopened this Apr 2, 2025
@IsaSih
Copy link
Contributor

IsaSih commented Apr 10, 2025

Feature works as expected. Validated in

Rancher v2.12-2a1bf3d05723fc0d85af3508302a641a4b89d6b7-head
Dashboard master eed2a33
Rancher Prime CLI v2.11.0-rc.1

Validated in dark theme, light theme, Suse/prime and Custom primary colors.
Focus on the following components were verified:

  • Input fields
  • dropdown lists
  • sorting filter
  • Checkboxes
  • Tooltips
  • Burguer menu and side menu
  • 3-dot buttons
  • Buttons
  • Radio buttons
  • Health bars

@IsaSih
Copy link
Contributor

IsaSih commented Apr 10, 2025

I have a question @rak-phillip: For all themes, in copy icons, the component gets a green background once selected, which outlies the expected behavior. Is this component covered in the scope of this issue? Do you know if this is expected?

Screen.Recording.2025-04-09.at.21.31.24.mov

@IsaSih
Copy link
Contributor

IsaSih commented Apr 10, 2025

I'm reopening the issue as the new focus colors are not being applied to toggles.

Screen.Recording.2025-04-09.at.21.44.02.mov
Screen.Recording.2025-04-09.at.21.15.56.mov

@rak-phillip
Copy link
Member

I have a question @rak-phillip: For all themes, in copy icons, the component gets a green background once selected, which outlies the expected behavior. Is this component covered in the scope of this issue? Do you know if this is expected?

No, that's the styling of the AsyncButton, which is setting the background color of the button on click. I think that we can open up a new issue to address this.

@rak-phillip
Copy link
Member

rak-phillip commented Apr 10, 2025

I'm reopening the issue as the new focus colors are not being applied to toggles.

This regression was introduced in #13880. It is unrelated to this issue and only affects 2.12.

edit: My above comment was for tracking purposes only. I will still raise a PR against this issue to address the problem.

@IsaSih
Copy link
Contributor

IsaSih commented Apr 10, 2025

Filed issue #14105 to address the focus style in copy icons

@IsaSih
Copy link
Contributor

IsaSih commented Apr 18, 2025

Re-opening as this wasn't re-tested

@IsaSih IsaSih reopened this Apr 18, 2025
@IsaSih
Copy link
Contributor

IsaSih commented Apr 19, 2025

Feature now works as expected.

Image Image

@IsaSih IsaSih closed this as completed Apr 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment