-
Notifications
You must be signed in to change notification settings - Fork 269
a11y: Ensure new focus colours work well with Prime branding #13566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Before passing to QA, let's spin up an instance and get a screenshot with prime branding and run it by UX. |
/backport v2.11.1 |
Reopening this issue because it didn't get picked up by automation. This should get closed after it passes QA. |
Feature works as expected. Validated in Rancher v2.12-2a1bf3d05723fc0d85af3508302a641a4b89d6b7-head Validated in dark theme, light theme, Suse/prime and Custom primary colors.
|
I have a question @rak-phillip: For all themes, in copy icons, the component gets a green background once selected, which outlies the expected behavior. Is this component covered in the scope of this issue? Do you know if this is expected? Screen.Recording.2025-04-09.at.21.31.24.mov |
I'm reopening the issue as the new focus colors are not being applied to toggles. Screen.Recording.2025-04-09.at.21.44.02.movScreen.Recording.2025-04-09.at.21.15.56.mov |
No, that's the styling of the AsyncButton, which is setting the background color of the button on click. I think that we can open up a new issue to address this. |
This regression was introduced in #13880. It is unrelated to this issue and only affects 2.12. edit: My above comment was for tracking purposes only. I will still raise a PR against this issue to address the problem. |
Filed issue #14105 to address the focus style in copy icons |
Re-opening as this wasn't re-tested |
The text was updated successfully, but these errors were encountered: