Skip to content

Commit 075f800

Browse files
authored
Switch from printing to logging (#18711)
Currently we print a notice when prefetching is enabled and we try to use a type that cannot be safely prefetched (essentially any nested type). We should not be printing unconditionally. Logging is more appropriate. Authors: - Vyas Ramasubramani (https://github.com/vyasr) - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) - Bradley Dice (https://github.com/bdice) - Vukasin Milovanovic (https://github.com/vuule) URL: #18711
1 parent b9a5e1a commit 075f800

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

cpp/src/column/column_view.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
#include <cudf/column/column_view.hpp>
1818
#include <cudf/detail/null_mask.hpp>
1919
#include <cudf/hashing/detail/hashing.hpp>
20+
#include <cudf/logger_macros.hpp>
2021
#include <cudf/strings/strings_column_view.hpp>
2122
#include <cudf/types.hpp>
2223
#include <cudf/utilities/default_stream.hpp>
@@ -55,8 +56,7 @@ void prefetch_col_data(ColumnView& col, void const* data_ptr, std::string_view k
5556
scv.chars_size(cudf::get_default_stream()) * sizeof(char),
5657
cudf::get_default_stream());
5758
} else {
58-
std::cout << key << ": Unsupported type: " << static_cast<int32_t>(col.type().id())
59-
<< std::endl;
59+
CUDF_LOG_DEBUG("Unsupported type: %d", static_cast<int32_t>(col.type().id()));
6060
}
6161
}
6262
}

0 commit comments

Comments
 (0)