Netty with accessEvents with logback-access

[bhochhi]

Why netty has no accessEvents but just accessLog implementation? Is there any plan supporting that?

[violetagg]

Such integration should be possible via https://projectreactor.io/docs/netty/release/api/reactor/netty/http/server/HttpServer.html#accessLog-boolean-reactor.netty.http.server.logging.AccessLogFactory-

Marking this as help wanted if somebody wants to work on this.

[childewuque]

Thanks
It would be better if we could configure instead of coding

[JooHyukKim]

has anyone worked on this yet?

[violetagg]

@JooHyukKim Currently nobody is working on this one.

[JooHyukKim]

@violetagg I see. Would you allow me to work on it? seems quite interesting

[JooHyukKim]

@violetagg @bhochhi I'd like to hear more about your thoughts on what AccessEvents are and how they should behave.

[violetagg]

@violetagg I see. Would you allow me to work on it? seems quite interesting

@JooHyukKim Yes sure

[violetagg]

@violetagg @bhochhi I'd like to hear more about your thoughts on what AccessEvents are and how they should behave.

I believe that @bhochhi meant integration with logback-access https://logback.qos.ch/access.html

[JooHyukKim]

trueeee. @bhochhi is that what you are suggesting? integration with logback-access like how Tomcat and Jetty are integrated with logback-access described in https://logback.qos.ch/access.html ?

[JooHyukKim]

logback-access is officailly described to integrate with Serverlet Containers such as Jetty or Tomcat.
As far as I know, we also need netty-specific Adaptor and ValveBase implementation in Logback-access.
looking at codebase of Tomcat and Jetty integration with logback-access.

Lemme know how you think :)
cheers

[bhochhi]

yes, I wanted Netty to support AccessEvent so that logback-access can be supported. However, my original question is Why Netty didn't have support? Is that by design or other limitations due to different paradigms?

[violetagg]

yes, I wanted Netty to support AccessEvent so that logback-access can be supported. However, my original question is Why Netty didn't have support? Is that by design or other limitations due to different paradigms?

I don't understand this.

In Tomcat you have Valve concept, here in Reactor Netty you have a mechanism for a custom implementation for the access logging https://projectreactor.io/docs/netty/release/api/reactor/netty/http/server/HttpServer.html#accessLog-boolean-reactor.netty.http.server.logging.AccessLogFactory-

[JooHyukKim]

I think this issue needs more clarification on exactly what the desired enhancement is 👍

[childewuque]

@JooHyukKim
#1752

For example, add remote host in logback.xml or in other file,like nginx format
Thanks

[JooHyukKim]

Such integration should be possible via https://projectreactor.io/docs/netty/release/api/reactor/netty/http/server/HttpServer.html#accessLog-boolean-reactor.netty.http.server.logging.AccessLogFactory-

Marking this as help wanted if somebody wants to work on this.

@childewuque
kindly suggest specific purpose and way to add the functionality? thanks.