Skip to content

2d aabb #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
duarm opened this issue Oct 9, 2023 · 1 comment · Fixed by #355
Closed

2d aabb #349

duarm opened this issue Oct 9, 2023 · 1 comment · Fixed by #355
Labels
feature request feature feedback wanted

Comments

@duarm
Copy link
Contributor

duarm commented Oct 9, 2023 •
edited
Loading

Been using my own 2d aabb implementation for some time, just noticed cglm now provides a 3d aabb (two vec3's), would a 2d version of the aabb functions be welcome? questions:

  • How the functions should be named? glm_aabb2d_size()? glm_aabs_size() (axis-aligned bounding-square, this one kinda goofy)?
  • The name of the file? currently the aabb functions are located on box.h, should we create a aabb2d.h? square.h?
@recp
Copy link
Owner

recp commented Oct 9, 2023

Hi @duarm,

would a 2d version of the aabb functions be welcome

Definitely, it would be nice to have 2d aabb :) aabb2d.h header and aabb2d namespace is fine. square.h would match box.h but in the future maybe we change box.h into aabb.h not sure but aabb2d.h can be used for now.

@duarm duarm mentioned this issue Nov 11, 2023
Merged
5 tasks
@recp recp closed this as completed in #355 Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request feature feedback wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

aabb2d duarm/cglm
2 participants
@recp @duarm