added precommit for trailing-whitespace

Author: garethahealy

.github/actions/setup-kind-cluster-for-helm-chart-testing/action.yaml

@@ -6,7 +6,7 @@ inputs:
     description: helm version to install
     required: true
     default: 'v3.16.3'
-  
+
   # renovate: datasource=github-tags depName=python/cpython
   python-version:
     description: python version to install
@@ -36,7 +36,7 @@ inputs:
     required: false
     default: 'registryuser1'
 
-  local-registry-password: 
+  local-registry-password:
     description: local authenticated registry password
     required: false
     default: 'registrypassword1'
@@ -70,7 +70,7 @@ runs:
       version: ${{ inputs.kind-version }}
       config: _test/kind-config.yaml
 
-  # for helm charts we are testing that require installing operators 
+  # for helm charts we are testing that require installing operators
   - name: Setup kind cluster - Install OLM 🧰
     env:
       OLM_VERSION: ${{ inputs.olm-version }}
@@ -121,7 +121,7 @@ runs:
         --set registryPassword=${LOCAL_REGISTRY_PASSWORD} \
         --set registryIngressHost=${LOCAL_REGISTRY_URI}
     if: inputs.local-registry-enabled == 'true'
-  
+
   # copy images needed by CT tests that use private registry to the private registry
   - name: Setup kind cluster - Copy images into private registry 🔺
     env:

.github/workflows/conftest.yaml

@@ -1,6 +1,6 @@
 name: Validate
 
-on: 
+on:
   push:
     paths-ignore:
       - '.github/**'

.github/workflows/install-integration-tests-operators-installer.yaml

@@ -29,7 +29,7 @@ jobs:
       uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
       with:
         fetch-depth: 0
-    
+
     # set up kind cluster (using re-usable local composite action)
     - name: Setup Kind Cluster for Helm Chart Testing 🧰
       uses: ./.github/actions/setup-kind-cluster-for-helm-chart-testing
@@ -93,7 +93,7 @@ jobs:
       uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
       with:
         fetch-depth: 0
-    
+
     # set up kind cluster (using re-usable local composite action)
     - name: Setup Kind Cluster for Helm Chart Testing 🧰
       uses: ./.github/actions/setup-kind-cluster-for-helm-chart-testing

.github/workflows/install-unit-test.yaml

@@ -25,8 +25,8 @@ jobs:
         fetch-depth: 0
 
     - name: Setup chart-testing 🧰
-      uses: helm/chart-testing-action@0d28d3144d3a25ea2cc349d6e59901c4ff469b3b # v2.7.0
-    
+      uses: helm/chart-testing-action@e6669bcd63d7cb57cb4380c33043eebe5d111992 # v2.6.1
+
     - name: Find changed Charts 🔎
       id: changed-charts
       run: |
@@ -35,7 +35,7 @@ jobs:
         if [[ -n "$changed" ]]; then
           echo "changed=true" >> $GITHUB_OUTPUT
         fi
-    
+
     # set up kind cluster (using re-usable local composite action)
     - name: Setup Kind Cluster for Helm Chart Testing 🧰
       uses: ./.github/actions/setup-kind-cluster-for-helm-chart-testing

.github/workflows/lint-test.yaml

@@ -1,6 +1,6 @@
 name: Lint Test
 
-on: 
+on:
   pull_request:
     paths-ignore:
       - '.github/**'

.github/workflows/release.yaml

@@ -58,7 +58,7 @@ jobs:
           for chart in ${packaged_charts}; do
             cosign sign-blob --yes ${chart}
           done
-          
+
           echo "hashes=$(sha256sum ${packaged_charts} | base64 -w0)" >> "$GITHUB_OUTPUT"
 
     outputs:

.pre-commit-config.yaml

@@ -6,7 +6,7 @@ repos:
       - id: check-shebang-scripts-are-executable
       - id: check-json
       - id: end-of-file-fixer
-      #- id: trailing-whitespace
+      - id: trailing-whitespace
   - repo: https://gitlab.cee.redhat.com/infosec-public/developer-workbench/tools.git
     rev: rh-pre-commit-2.3.2
     hooks:

README.md

@@ -42,7 +42,7 @@ helm install my-jenkins -f my-values.yaml redhat-cop/jenkins
 
 ## 🏃‍♂️💨 Chart linting
 
-Before adding a chart to this repo, make sure there is no linting issues, otherwise the PR actions will fail. 
+Before adding a chart to this repo, make sure there is no linting issues, otherwise the PR actions will fail.
 We use both the integrated [`helm lint`](https://helm.sh/docs/helm/helm_lint/) command and the [`chart testing`](https://github.com/helm/chart-testing/blob/master/doc/ct_lint.md) tool.
 
 ```bash

charts-we-like.md

@@ -2,7 +2,7 @@
 Below is a collection of charts we've used in the past that run on OpenShift with examples and the values to get up and going:
 
 #### 🕵️‍♀️ Sealed Secrets
-[Sealed Secrets](https://github.com/bitnami-labs/sealed-secrets/tree/main/helm/sealed-secrets) 
+[Sealed Secrets](https://github.com/bitnami-labs/sealed-secrets/tree/main/helm/sealed-secrets)
 allows you to encrypt your K8s Secret into a SealedSecret, which is safe to store - even to a public repository:
 
 ```yaml
@@ -31,7 +31,7 @@ mysql:
 ```
 
 #### 🧪 Zalenium
-[Zalenium](https://github.com/zalando/zalenium/tree/master/charts/zalenium) 
+[Zalenium](https://github.com/zalando/zalenium/tree/master/charts/zalenium)
 is a Selenium Grid deployment with on demand provisioning of the browsers for running your tests:
 
 ```yaml
@@ -71,7 +71,7 @@ route:
 ```
 
 #### 🦟 Hoverfly
-[Hoverfly](https://github.com/helm/charts/tree/master/incubator/hoverfly) 
+[Hoverfly](https://github.com/helm/charts/tree/master/incubator/hoverfly)
 is a lightweight, open source API simulation tool. Using Hoverfly, you can create realistic simulations of the APIs your application depends on:
 
 ```yaml
@@ -87,7 +87,7 @@ openshift:
 ```
 
 #### 🗝 Vault
-[Vault](https://github.com/hashicorp/vault-helm.git) 
+[Vault](https://github.com/hashicorp/vault-helm.git)
 helps you to store and control access to your tokens, passwords, certificates, API keys and other secrets.
 
 ```yaml
@@ -121,7 +121,7 @@ server:
 ```
 
 ### 🚉 EAP
-[EAP](https://github.com/jbossas/eap-charts.git) 
+[EAP](https://github.com/jbossas/eap-charts.git)
 is Red Hat's [Jakarta EE offering](https://www.redhat.com/en/technologies/jboss-middleware/application-platform)
 
 ```yaml

charts/ansible-automation-platform/templates/wait-for-crd.yaml

@@ -3,15 +3,15 @@
 apiVersion: v1
 kind: Pod
 metadata:
-  name: cluster-check 
+  name: cluster-check
   annotations:
     "helm.sh/hook": post-install,post-upgrade
     "helm.sh/hook-weight": "-1"
     "helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded
   namespace: {{ .Values.namespace }}
 spec:
   containers:
-    - name: crd-check 
+    - name: crd-check
       image: quay.io/openshift/origin-cli:4.7
       imagePullPolicy: IfNotPresent
       command: ['sh', '-c', 'while [ true ]; do oc get crd automationcontrollers.automationcontroller.ansible.com; if [ $? -eq 0 ]; then break; fi ; sleep 5s; done']

charts/bootstrap-project/templates/operatorgroup.yaml

@@ -8,7 +8,7 @@ metadata:
   name: {{ .name }}-og
   namespace: {{ .name | quote }}
 spec:
-  targetNamespaces: 
+  targetNamespaces:
   - {{ .name }}
 {{- end }}
 {{- end }}

charts/cert-manager-configs/README.md

@@ -37,7 +37,7 @@ While the cert-manager install can be done with mostly default values, these con
 ```bash
 helm template cert-manager-configs -f charts/cert-manager-configs/values.yaml ./charts/cert-manager-configs | oc apply -f -
 ```
- 
+
 ### Configuration
 
 See comments in [values.yaml](./values.yaml) for more details on configuration

charts/dev-ex-dashboard/templates/configmap.yaml

@@ -7,7 +7,7 @@ metadata:
   annotations:
     argocd.argoproj.io/compare-options: IgnoreExtraneous
     argocd.argoproj.io/sync-options: Prune=false
-data: 
+data:
   conf: |
     {{- .Values.config | toYaml | nindent 4 }}
 {{- end }}

charts/dev-ex-dashboard/templates/deploymentconfig.yaml

@@ -68,4 +68,4 @@ spec:
         name: {{ .Values.app_name }}:{{ .Values.deployment.image.tag }}
       lastTriggeredImage: ""
     type: ImageChange
-  - type: ConfigChange  
+  - type: ConfigChange

charts/dev-ex-dashboard/templates/imagestream.yaml

@@ -2,7 +2,7 @@
 apiVersion: image.openshift.io/v1
 kind: ImageStream
 metadata:
-  creationTimestamp: null  
+  creationTimestamp: null
   labels:
     app: {{ .Values.app_name }}
   name: {{ .Values.app_name }}

charts/gitops-operator/TEAM_DOCS.md

@@ -370,7 +370,7 @@ We use a helm chart that deploys:
 Everyone will need to be given `edit` access to the `openshift-gitops` namespace e.g. as a `cluster-admin` user:
 
 ```bash
-# allow labs-admin group edit access to 
+# allow labs-admin group edit access to
 oc adm policy add-role-to-group edit labs-admins -n openshift-gitops
 ```
 

charts/gitops-operator/templates/wait-for-crd.yaml

@@ -3,15 +3,15 @@
 apiVersion: v1
 kind: Pod
 metadata:
-  name: cluster-check 
+  name: cluster-check
   annotations:
     "helm.sh/hook": post-install,post-upgrade
     "helm.sh/hook-weight": "-1"
     "helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded
   namespace: {{ .Release.Namespace }}
 spec:
   containers:
-  - name: crd-check 
+  - name: crd-check
     image: quay.io/openshift/origin-cli:latest
     imagePullPolicy: IfNotPresent
     command: ['sh', '-c', 'while [ true ]; do oc get crd argocds.argoproj.io applications.argoproj.io appprojects.argoproj.io; if [ $? -eq 0 ]; then break; fi ; sleep 5s; done']

charts/helper-operator/README.md

@@ -6,7 +6,7 @@
 
   ![Version: 1.0.26](https://img.shields.io/badge/Version-1.0.26-informational?style=flat-square)
 
- 
+
 
   ## Description
 

charts/helper-operator/README.md.gotmpl

@@ -1,6 +1,6 @@
 {{ template "doc.header" . }}
 
-This chart can be used to install Operators in OpenShift. 
+This chart can be used to install Operators in OpenShift.
 It is best used with a GitOps approach such as Argo CD does. For example: https://github.com/tjungbauer/openshift-clusterconfig-gitops
 
 This chart will create the objects: Namespace, Subscription, OperatorGroup and a Job, that will enable additional console plugins, if enabled.

charts/helper-status-checker/README.md

@@ -6,7 +6,7 @@
 
   ![Version: 4.0.9](https://img.shields.io/badge/Version-4.0.9-informational?style=flat-square)
 
- 
+
 
   ## Description
 

charts/helper-status-checker/README.md.gotmpl

@@ -1,14 +1,14 @@
 {{ template "doc.header" . }}
 
-This chart is used the check the installation status of an Operator. 
+This chart is used the check the installation status of an Operator.
 Whenever a new Operator gets installed, this Chart can be called to verify if the status of the Operator is ready.
 This is useful when you want to install an Operator AND configure it in the same Helm Chart. Typically, Argo CD will fail in such case,
 because it would try to configure the CRD that the Operator provides immediately after the Subscription object becomes ready. However,
 the CRD is not available yet, since the Operator is still installing itself.
 
 It is best used as a Subchart, for example, https://github.com/tjungbauer/helm-charts/tree/main/charts/rhacm-full-stack
 
-helper-status-checker will create a Service Account (incl. a ClusterRole and a ClusterRoleBinding) and a Job that will try to check the status of the Operator. If the Operator is not available after some time (configurable with mx_retries), the Job will fail. 
+helper-status-checker will create a Service Account (incl. a ClusterRole and a ClusterRoleBinding) and a Job that will try to check the status of the Operator. If the Operator is not available after some time (configurable with mx_retries), the Job will fail.
 
 NOTE: This chart can also be used to automatically approve an InstallPlan
 

charts/helper-status-checker/templates/check_if_operator_is_ready.yaml

@@ -115,7 +115,7 @@ spec:
              oc get clusterserviceversion -n {{ .namespace.name }} $get_exact_name
 
              echo "Falling to sleep"
-            
+
              SLEEPER_TMP=0
 
              while [[ $SLEEPER_TMP -le "10" ]]; do

charts/helper-status-checker/templates/installplan-approver.yaml

@@ -28,7 +28,7 @@ spec:
 
               SLEEPER_TMP=1
               SLEEPER_MOD=10
-               while [[ $SLEEPER_TMP -le "$sleep_timer" ]]; do   
+               while [[ $SLEEPER_TMP -le "$sleep_timer" ]]; do
                  if (( $SLEEPER_TMP % 10 == 0 ))
                  then
                    echo -n "$SLEEPER_MOD"

charts/ipa/setup-users.sh

@@ -12,12 +12,12 @@ oc rsh `oc get po -l deploymentconfig=${IPA_RELEASE_NAME}-ipa -o name -n ${IPA_N
 echo 'Passw0rd' | kinit admin
 export GROUP_NAME=student
 ipa group-add ${GROUP_NAME} --desc "TL500 Other" || true
-# in a loop add random users to the group 
+# in a loop add random users to the group
 for i in {1..24};do
   export LAB_NUMBER="lab$i"
   printf "\n\nI is user login ${LAB_NUMBER}"
   PASSWD=$(ipa user-add ${LAB_NUMBER} --first=${LAB_NUMBER} --last=${LAB_NUMBER} --email=${LAB_NUMBER}@redhatlabs.dev --random | grep Random)
-  printf "My creds are ${PASSWD}\n\n"  
+  printf "My creds are ${PASSWD}\n\n"
   ipa group-add-member ${GROUP_NAME} --users=$LAB_NUMBER
 done
 
@@ -26,7 +26,7 @@ done
 # alternative setup - provide silly passwords for users
 export GROUP_NAME=student
 ipa group-add ${GROUP_NAME} --desc "TL500 Student Group" || true
-# in a loop add random users to the group 
+# in a loop add random users to the group
 for i in {1..4};do
   export LAB_NUMBER="lab$i"
   echo 'thisisthepassword' | ipa user-add ${LAB_NUMBER} --first=${LAB_NUMBER} --last=${LAB_NUMBER} --email=${LAB_NUMBER}@redhatlabs.dev --password

charts/jenkins/templates/buildconfigs.yaml

@@ -40,7 +40,7 @@ spec:
     contextDir: {{ .source_context_dir | quote }}
     {{- else }}
     contextDir: "jenkins-agents/{{ .name }}"
-    {{- end }}      
+    {{- end }}
   strategy:
 {{- if .strategy_type }}
     type: {{ .strategy_type }}

charts/jenkins/templates/deployment.yaml

@@ -1,6 +1,6 @@
 {{- if .Values.deployment }}
 ---
-apiVersion: apps/v1 
+apiVersion: apps/v1
 kind: Deployment
 metadata:
   annotations:
@@ -14,7 +14,7 @@ spec:
     matchLabels:
       app.kubernetes.io/name: {{ .Values.appName }}
   strategy: {{- if .Values.persistence }}
-    type: Recreate 
+    type: Recreate
     {{ else }}
     type: RollingUpdate
     {{- end }}
@@ -29,7 +29,7 @@ spec:
         - name: OPENSHIFT_ENABLE_OAUTH
           value: "true"
         - name: OPENSHIFT_ENABLE_REDIRECT_PROMPT
-          value: "true" 
+          value: "true"
           {{- end }}
         - name: KUBERNETES_MASTER
           value: https://kubernetes.default:443

charts/network-policy/templates/NetworkPolicy.yaml

@@ -1,7 +1,7 @@
 {{- if .Values.enabled }}
 {{ $labels := include "network-policy.labels" . }}
 {{ $all_policies := .Values.policies }}
-{{ if ne 0 (len .Values.multitenant_policies) }} 
+{{ if ne 0 (len .Values.multitenant_policies) }}
 {{ $all_policies = concat .Values.policies .Values.multitenant_policies }}
 {{ end }}
 {{- range $all_policies }}
@@ -13,7 +13,7 @@ metadata:
   labels:
     {{- $labels | nindent 4 }}
   name: {{ .name }}
-spec: 
+spec:
 {{ toYaml .spec | indent 2 }}
 {{ end }}
 {{ end }}

charts/operatorhub/templates/install-modes-post-hook.yaml

@@ -60,7 +60,7 @@ spec:
         command:
           - /bin/bash
           - -c
-          - | #TODO: Get the CSV from the cluster instead from a var? 
+          - | #TODO: Get the CSV from the cluster instead from a var?
               oc -n {{ $op.namespace }} patch csv {{ $op.subscription.csv }} --type=merge -p '{"spec":{"installModes":[{"supported": {{ $im.OwnNamespace }}, "type":"OwnNamespace"},{"supported": {{ $im.SingleNamespace }}, "type":"SingleNamespace"},{"supported": {{ $im.MultiNamespace }}, "type":"MultiNamespace"},{"supported": {{ $im.AllNamespaces }}, "type":"AllNamespaces"}]}}'
 {{- end }}
 {{- end }}