Skip to content

Commit a2340f4

Browse files
gengjiawenrefack
authored andcommitted
console: improve code readability
use object spread to make console code more readable PR-URL: nodejs#24412 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
1 parent f3cac61 commit a2340f4

File tree

1 file changed

+16
-13
lines changed

1 file changed

+16
-13
lines changed

lib/console.js

Lines changed: 16 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -97,23 +97,26 @@ function Console(options /* or: stdout, stderr, ignoreErrors = true */) {
9797
throw new ERR_CONSOLE_WRITABLE_STREAM('stderr');
9898
}
9999

100-
var prop = {
100+
const prop = {
101101
writable: true,
102102
enumerable: false,
103103
configurable: true
104104
};
105-
prop.value = stdout;
106-
Object.defineProperty(this, '_stdout', prop);
107-
prop.value = stderr;
108-
Object.defineProperty(this, '_stderr', prop);
109-
prop.value = Boolean(ignoreErrors);
110-
Object.defineProperty(this, '_ignoreErrors', prop);
111-
prop.value = new Map();
112-
Object.defineProperty(this, '_times', prop);
113-
prop.value = createWriteErrorHandler(stdout);
114-
Object.defineProperty(this, '_stdoutErrorHandler', prop);
115-
prop.value = createWriteErrorHandler(stderr);
116-
Object.defineProperty(this, '_stderrErrorHandler', prop);
105+
Object.defineProperty(this, '_stdout', { ...prop, value: stdout });
106+
Object.defineProperty(this, '_stderr', { ...prop, value: stderr });
107+
Object.defineProperty(this, '_ignoreErrors', {
108+
...prop,
109+
value: Boolean(ignoreErrors),
110+
});
111+
Object.defineProperty(this, '_times', { ...prop, value: new Map() });
112+
Object.defineProperty(this, '_stdoutErrorHandler', {
113+
...prop,
114+
value: createWriteErrorHandler(stdout),
115+
});
116+
Object.defineProperty(this, '_stderrErrorHandler', {
117+
...prop,
118+
value: createWriteErrorHandler(stderr),
119+
});
117120

118121
if (typeof colorMode !== 'boolean' && colorMode !== 'auto')
119122
throw new ERR_INVALID_ARG_VALUE('colorMode', colorMode);

0 commit comments

Comments
 (0)