The prHourlyLimit counter for Gerrit gets incremented even when change is not actually created

[felipecrs]

How are you running Renovate?

Self-hosted Renovate

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

Gerrit

Please tell us more about your question or problem

I have been debugging and fine-tuning change limits with Gerrit platform for the past month, and I realized one buggy behavior:

1. As we know, Renovate will update the prHourlyLimit counter every time the createPr() function succeeds (here).

2. However, createPr() function in Gerrit does not actually create the change. The change gets created as part of git.commitAndPush().

   In that case, createPr() will only ensure the PR was created at the earlier git.commitAndPush() call.

3. For some reason, Renovate calls git.commitAndPush() && createPr() even when the change already exists.

   To account for that, Gerrit's commitAndPush() will ensure not to push anything in case it was pushed earlier (here).

   Renovate then calls createPr() and increments the counter, even though no change was created at all.

Logs (if relevant)

No response

[felipecrs]

The prConcurrentLimit counter seems to be affected by the same issue in Gerrit platform. Looks like disabling prConcurrentLimit and setting branchConcurrentLimit works better.

By the way, I'm working around prHourlyLimit with prCommitsPerRunLimit, provided I always run one Renovate process per repository.