Skip to content

Minimum version of FUSE for 2.1 release #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lechner opened this issue Aug 18, 2021 · 8 comments
Closed

Minimum version of FUSE for 2.1 release #594

lechner opened this issue Aug 18, 2021 · 8 comments

Comments

@lechner
Copy link
Contributor

lechner commented Aug 18, 2021

Hi,

I tried to build 2.1 for Debian today but got the error below. What is the current minimum version of FUSE, please?

Is the return type adjusted in golang-github-hanwen-go-fuse 2.1.0 (which is quite similar to your current release version)?

Thank you!

Kind regards
Felix Lechner

github.com/rfjakob/gocryptfs/internal/fusefrontend_reverse
# github.com/rfjakob/gocryptfs/internal/fusefrontend_reverse
src/github.com/rfjakob/gocryptfs/internal/fusefrontend_reverse/excluder.go:23:2: too many arguments to return
        have (*ignore.GitIgnore, error)
        want (*ignore.GitIgnore)
@rfjakob
Copy link
Owner

rfjakob commented Aug 18, 2021

https://github.com/sabhiram/go-gitignore has changed, it's this commit: sabhiram/go-gitignore@223ce5d

Edit: Requested v2.0 release from @sabhiram : sabhiram/go-gitignore#17

@rfjakob
Copy link
Owner

rfjakob commented Aug 18, 2021

Hmm, but i see that the author has not created a release after this change. If this causes pain for debian, I can revert back to the older go-gitignore version. I don't think there are any bugfixes.

@lechner
Copy link
Contributor Author

lechner commented Aug 18, 2021

I can revert back

Not necessary; I can simply patch the Debian version. Please just identify your commit.

I can conveniently carry the patch forward as needed, which may not require a tagged release there.

Ubuntu may soft-freeze tomorrow, so your timely advice could help getting 2.1 in there. Thanks!

Kind regards
Felix Lechner

@rfjakob
Copy link
Owner

rfjakob commented Aug 18, 2021

a7fa917

@rfjakob
Copy link
Owner

rfjakob commented Aug 18, 2021

Note that go-fuse has seen some important fixes too, most important imo is hanwen/go-fuse@a90e1f4 , which fixed #549

@lechner
Copy link
Contributor Author

lechner commented Aug 18, 2021

Unfortunately, I do not maintain go-fuse and cannot ethically effect an upload in time for the Ubuntu freeze (there are no technical obstacles) but I will make sure Debian receives an update soon.

@lechner
Copy link
Contributor Author

lechner commented Aug 18, 2021

Hi, how about this one?

src/github.com/rfjakob/gocryptfs/mount.go:374:8: mOpts.EnableAcl undefined (type *fuse.MountOptions has no field or method EnableAcl)
dh_auto_build: error: cd obj-x86_64-linux-gnu && go install -trimpath -v -p 8 -ldflags "-X main.GitVersion=2.1 -X main.GitVersionFuse=2.0.3 -X main.BuildDate=2021-08-18" github.com/rfjakob/gocryptfs github.com/rfjakob/gocryptfs/contrib/atomicrename github.com/rfjakob/gocryptfs/contrib/findholes github.com/rfjakob/gocryptfs/contrib/findholes/holes github.com/rfjakob/gocryptfs/contrib/getdents-debug/getdents github.com/rfjakob/gocryptfs/contrib/getdents-debug/readdirnames github.com/rfjakob/gocryptfs/contrib/statfs github.com/rfjakob/gocryptfs/contrib/statvsfstat github.com/rfjakob/gocryptfs/ctlsock github.com/rfjakob/gocryptfs/gocryptfs-xray github.com/rfjakob/gocryptfs/internal/configfile github.com/rfjakob/gocryptfs/internal/contentenc github.com/rfjakob/gocryptfs/internal/cryptocore github.com/rfjakob/gocryptfs/internal/ctlsocksrv github.com/rfjakob/gocryptfs/internal/ensurefds012 github.com/rfjakob/gocryptfs/internal/exitcodes github.com/rfjakob/gocryptfs/internal/fido2 github.com/rfjakob/gocryptfs/internal/fusefrontend github.com/rfjakob/gocryptfs/internal/fusefrontend_reverse github.com/rfjakob/gocryptfs/internal/inomap github.com/rfjakob/gocryptfs/internal/nametransform github.com/rfjakob/gocryptfs/internal/openfiletable github.com/rfjakob/gocryptfs/internal/pathiv github.com/rfjakob/gocryptfs/internal/readpassword github.com/rfjakob/gocryptfs/internal/serialize_reads github.com/rfjakob/gocryptfs/internal/siv_aead github.com/rfjakob/gocryptfs/internal/speed github.com/rfjakob/gocryptfs/internal/stupidgcm github.com/rfjakob/gocryptfs/internal/syscallcompat github.com/rfjakob/gocryptfs/internal/tlog returned exit code 2

@rfjakob
Copy link
Owner

rfjakob commented Aug 19, 2021

Needs this commit hanwen/go-fuse@62c5aa1

@rfjakob rfjakob closed this as completed Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants